problems with threads in my program (runnable)

[runn81]

hey all!

I've got a problem with my homework I cannot get past throu I am quite sure that it is very simple one and somebody will be able to help me.

I have to write a program that starts and controls thread from diffrent class that implements runnable.

this is class with a thread i've got:

public class Liczby implements Runnable {
	
	boolean stopped = false;
	boolean suspended = false;

	public void run() {
		int iii = 0;
		
		while(!stopped) {
			while (!suspended) {
		         try {
					Thread.sleep(200);
				} catch (InterruptedException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
			System.out.println(iii);
			iii++;
		}	
		}
		if (stopped) { System.out.println(iii); }
	    if (suspended) {
	    	try {
				synchronized(this) {
					wait();
				}
			} catch (Exception e) {
				System.err.println("Exception w wait");
			}
	    	System.out.println("Watek wstrzymany na wartosci " + iii);
	    }
	    }
	
	
	
	public void start() {
		run();		
	}


	public void interrupt() {
		interrupt();		
	}
	
	  public void stopThread() {
		    stopped = true;
		  }

	  public void suspendThread() {
		    suspended = true;
		  }

	  public void resumeThread() {
		    suspended = false;
		    synchronized(this) {
		      notify();
		    }
	  }
}

and this is class that supouse to control it:

import javax.swing.JOptionPane;


public class LiczbyKontroler {

	/**
	 * @param args
	 */

			
			  public static void main(String args[]) {
			    String msg = "I = interrupt\n" +
			                 "E = end\n" +
			                 "S = suspend\n" +
			                 "R = resume\n" +
			                 "N = new start";

				Thread liczby = new Thread(new Liczby());
				liczby.start();
			    String cmd;
			    while ((cmd = JOptionPane.showInputDialog(msg)) != null) {
			      char c = cmd.charAt(0);
			      switch (c) {
			        case 'I' : liczby.interrupt(); break;
			        case 'E' : liczby.stopThread(); break;
			        case 'S' : liczby.suspendThread(); break;
			        case 'R' : liczby.resumeThread(); break;
			        case 'N' : if (liczby.isAlive())
			                     JOptionPane.showMessageDialog(null, "Thread alive!!!");
			                   else {
			                     liczby = new Liczby();
			                     liczby.start();
			                   }
			                   break;
			        default  : break;
			      }
			    }
			    System.exit(0);
			  }
			}

the problem is i cannot access methods stopThread, suspendThread and resumeThread from class Liczby and I am stuck dunno what to do. I tried to run liczby as object of cass Liczby instead Thread but this way i cannot run it at the some time with panel to control it. Please help! I know if class Liczby was extending Thread would be no problem, cheers.

[sunde887]

You will get a lot more people helping you if you wrap your code in code tags. It makes the code much easier to read.

To do this type [code] before any code, then paste your code in, then put [/code] at the end of the code

[code]
YOUR CODE HERE
[/code]

It will look like this

YOUR CODE HERE

[runn81]

thx for telling me and i'm sorry as i am new to forum

[kjkrum]

First, please post your code within code tags.

Second, post the exact errors you are getting.

Third, I'm really not clear what you're asking, but your choice of method names is worrying. You should never use Thread.stop or Thread.suspend. Here's why. You do seem to be following the advice under "What should I use instead of Thread.stop?", but you need to synchronize access to your 'stopped' and 'suspended' variables.

[kjkrum]

Sunde, how do you show what a code tag looks like without it being interpreted as a code tag?

[runn81]

i will try to explain it as clear as i can :)

class Liczby has got methods:

public void stopThread() {
		    stopped = true;
		  }

	  public void suspendThread() {
		    suspended = true;
		  }

	  public void resumeThread() {
		    suspended = false;
		    synchronized(this) {
		      notify();

these methods basically change boolean from true to false

and when I am in class LiczbyKontroler and I am trying to stop thread called "liczby" by method "stopThread" from class Liczby:

                                case 'E' : liczby.stopThread(); break;
			        case 'S' : liczby.suspendThread(); break;
			        case 'R' : liczby.resumeThread(); break;

i get this:

The method resumeThread() is undefined for the type Thread
	Type mismatch: cannot convert from Liczby to Thread

	at LiczbyKontroler.main(LiczbyKontroler.java:25)

basically if class Liczby was extending Thread there would be no problem whatsoever but my teacher wants the class Liczby to be:

 public class Liczby implements Runnable

when i copied the code into different class that extends Thread there was no errors.

thx

[kjkrum]

The method resumeThread() is undefined for the type Thread
	Type mismatch: cannot convert from Liczby to Thread

	at LiczbyKontroler.main(LiczbyKontroler.java:25)

This line is the problem:

liczby = new Liczby();

Because the type of the variable liczby is not Liczby. It's Thread. Your Liczby is anonymous:

Thread liczby = new Thread(new Liczby());

Instead, perhaps you should do this:

Liczby liczby = new Liczby();
Thread thread = new Thread(liczby);

Your methods that change the booleans need to be synchronized. The loop conditions that read those booleans also need to be synchronized. Synchronization in Java is not just about atomicity or exclusivity. Changes to variables are not guaranteed to be visible to other threads unless the reads and writes are synchronized.

[runn81]

cheers for help good people of java-forums but i am afraid:

Exception in thread "main" java.lang.Error: Unresolved compilation problems: 
	The method stopThread() is undefined for the type Thread
	The method suspendThread() is undefined for the type Thread
	The method resumeThread() is undefined for the type Thread

	at LiczbyKontroler.main(LiczbyKontroler.java:26)

basically it is very similiar problem.
this seriously frustrates me cous i spent to much time on this thing already and it is after midnight and i cant sleep cous of that. and i am sure it is trivial thing that needs to be changed! nothing come tos me mind i will have to sleep it over and start tomorow. thx again.

[DarrylBurke]

Sunde, how do you show what a code tag looks like without it being interpreted as a code tag?

Quote Sunde's post to see that.

db

[ra4king]

cheers for help good people of java-forums but i am afraid:

Exception in thread "main" java.lang.Error: Unresolved compilation problems: 
	The method stopThread() is undefined for the type Thread
	The method suspendThread() is undefined for the type Thread
	The method resumeThread() is undefined for the type Thread

	at LiczbyKontroler.main(LiczbyKontroler.java:26)

basically it is very similiar problem.
this seriously frustrates me cous i spent to much time on this thing already and it is after midnight and i cant sleep cous of that. and i am sure it is trivial thing that needs to be changed! nothing come tos me mind i will have to sleep it over and start tomorow. thx again.

Those methods don't exist in the class Thread. You need to call those methods on an object of class Liczby.

[sunde887]

As darryl said, if you quote my post you will see I actually put before the code. So it looks something like this(without spaces of course
[[i][ /i]code]
YOUR CODE HERE
[/code]

[runn81]

Those methods don't exist in the class Thread. You need to call those methods on an object of class Liczby.

thx 4 ur response

How do I do it? I tried and ultimately failed big time :)

[kjkrum]

Look at the last piece of code in my earlier comment.