Timer thread.

[eddie6]

I need to know how long my server program has been active so I've created a basic timer. Only problem it uses 90-100% extra CPU once I start this thread. I want to make it only run every second until a minute then only every minute until an hour and then only every hour. I'm just not sure how. Or really anyother way to make it more efficient.

Thank you so much to anyone who can help me.

Heres my code

private class timeKeeping implements Runnable {
        private boolean running = false;
        private long serverStartTime;
        private ServerUI theInterface;
        public timeKeeping(long startTime, ServerUI theInterface) {
            running = true;
            this.serverStartTime = startTime;
            this.theInterface = theInterface;
        }
        public void run() {
            while(running) {
                long serverUpTime = System.currentTimeMillis() - serverStartTime;
                long time;
                String units;
                if((serverUpTime/1000) < 60) {
                    time = serverUpTime/1000;
                    units = "seconds";
                } else if((serverUpTime/1000) > 60 && (serverUpTime/1000) < 3600) {
                    time = (serverUpTime/1000)/60;
                    units = "minutes";
                } else {
                    time = ((serverUpTime/1000)/60)/60;
                    units = "hours";
                }
                theInterface.setServerUpTime(time+" "+units);
            }
        }
        public void stop() {
            running = false;
        }
    }

[KevinWorkman]

Are you just looking for Thread.sleep()? I'd recommend reading through the API.

Java Platform SE 6
And this: http://download.oracle.com/javase/tu...l/concurrency/

[eddie6]

worked perfectly thanks!! Just added Thread.sleep(); at the end and it solved the problem. Netbeans does give me a warning saying .sleep called in loop. Does this matter?

[KevinWorkman]

You are passing an argument into sleep(), right? And I don't know what the warning is. Does the program work how you want it to?

[eddie6]

Works fine. yeah I'm sleeping 1000.
But netbeans says Warning: Thread.sleep called in loop.

Can't see anything wrong with it tho. Program works fine and CPU is down from about 98% to 2.7%. So I'm happy anyway. Thanks.

[BZwap]

thanks Kevin

[d3n1s]

netbeans is warning you because it can cause issues when sleeping in a thread (like the program hanging for example) but in your case it is a controlled sleep and you know exactly what is going on and how long it is sleeping so do not worry about it. I also have a timer and get the same warning, it is perfectly OK as long as you are fully aware of what's going on.