Results 1 to 5 of 5
  1. #1
    Rebugger is offline CS Student
    Join Date
    Jul 2014
    Posts
    7
    Rep Power
    0

    Default Is it ok to ask for feedback on my code?

    I have been working on a (rather simple) program for a month now and have finally finished it and done some basic alpha testing. However, I would really love to get some feedback on my code and get suggestions for what I could do better to improve my future projects.

    Is it ok to ask this on java-forums or is it against the rules?

    Just thought I'd ask this first to make sure.

    If it is allowed, which area will be best to post in?

  2. #2
    gimbal2 is offline Just a guy
    Join Date
    Jun 2013
    Location
    Netherlands
    Posts
    5,114
    Rep Power
    12

    Default Re: Is it ok to ask for feedback on my code?

    Hey it never hurts to try, but it kind of depends on how big the application is just how much response you will get; if there are many classes / lots of lines of code, I wouldn't expect more than a quick glance and some shallow comments. People here tend to post during work time you know, nobody will have the time to take half an hour to look at someone else's code. Except for me, because I am actually a spambot that infected this forum. Don't tell the mods ;)

    Instead of posting the entire thing, try reviewing your own code and posting snippets you think yourself could need improving. Try to narrow the focus.

    As for which forum: I'd just use the forum lobby or 'new to java' if I were you. There is a reviews/advertisement forum but that is really just a trap for spammers and advertisers.
    "Syntactic sugar causes cancer of the semicolon." -- Alan Perlis

  3. #3
    KevinWorkman's Avatar
    KevinWorkman is offline Crazy Cat Lady
    Join Date
    Oct 2010
    Location
    Washington, DC
    Posts
    4,143
    Rep Power
    14

    Default Re: Is it ok to ask for feedback on my code?

    Like gimbal said, it's certainly not against the rules, but not many people will want to trudge through hundreds of lines of code between multiple classes just to tell you to clean up your syntax.

    If you're just learning how to code, I think it's a bit of a waste of time to focus on optimization too much. In 6 months you'll be able to look back at your code and think "oh man that's horrible, did I really write that?" and fix it up yourself. Trying to make your code perfect now is just a waste of time that would be better spent just programming your next project. The best way to learn how to program is by programming.

    That being said, you might want to post MCVEs of particular parts of your code, that way we can copy and paste it into a single file in our editors and run your code ourselves. You're much more likely to get help if you post an MCVE instead of your whole project.

    There is also a Stack Exchange devoted to reviewing code that you might want to check out: Code Review Stack Exchange

    Quote Originally Posted by gimbal2 View Post
    As for which forum: I'd just use the forum lobby or 'new to java' if I were you. There is a reviews/advertisement forum but that is really just a trap for spammers and advertisers.
    I've been waging a personal war against the spammers in this section. It's looking much more trimmed now!
    How to Ask Questions the Smart Way
    Static Void Games - GameDev tutorials, free Java and JavaScript hosting!
    Static Void Games forum - Come say hello!

  4. #4
    jim829 is offline Senior Member
    Join Date
    Jan 2013
    Location
    Northern Virginia, United States
    Posts
    6,226
    Rep Power
    13

    Default Re: Is it ok to ask for feedback on my code?

    Quote Originally Posted by Rebugger View Post
    I have been working on a (rather simple) program for a month now and have finally finished it and done some basic alpha testing. However, I would really love to get some feedback on my code and get suggestions for what I could do better to improve my future projects.
    Your request is certainly one approach. But I have a different perspective on this. Don't worry
    too much how it looks on the inside (as long as it works). Some guy took four years to write a
    Sudoku program and he made a lot of money off of it. He clearly wasn't a programmer and I can
    only imagine what his code looked like. But the GUI was pretty good.

    So just tuck the program away, and keep on developing but also keep studying and reading and
    looking at other folks' code (I find reading the JDK source very informative). Then go back and look
    at some of the first code you wrote. If you're like me you will wonder how you could have written such
    garbage.

    Regards,
    Jim
    The JavaTM Tutorials | SSCCE | Java Naming Conventions
    Poor planning on your part does not constitute an emergency on my part

  5. #5
    KevinWorkman's Avatar
    KevinWorkman is offline Crazy Cat Lady
    Join Date
    Oct 2010
    Location
    Washington, DC
    Posts
    4,143
    Rep Power
    14

    Default Re: Is it ok to ask for feedback on my code?

    What Jim said.
    How to Ask Questions the Smart Way
    Static Void Games - GameDev tutorials, free Java and JavaScript hosting!
    Static Void Games forum - Come say hello!

Similar Threads

  1. Need feedback with my code, thank you
    By Dai in forum New To Java
    Replies: 10
    Last Post: 09-19-2013, 08:43 AM
  2. Need Code Feedback | And Why Do I Get This Error?
    By megarobot524 in forum New To Java
    Replies: 1
    Last Post: 09-19-2013, 06:37 AM
  3. UML feedback
    By behedwin in forum New To Java
    Replies: 0
    Last Post: 10-05-2012, 11:21 AM
  4. Feedback
    By GrumpyBum in forum Suggestions & Feedback
    Replies: 0
    Last Post: 04-25-2012, 11:34 AM
  5. Feedback on my PrimeNumber Finder code please.
    By fatabass in forum New To Java
    Replies: 4
    Last Post: 12-22-2011, 10:43 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •