Looks like I’m doing procedural programming

[luckylucky]

Any tips to make it more OOP?
It’s my first Java program to calculate the total cost of elixir during an attack in the game Clan of Clash.

import java.io.BufferedReader;
import java.io.InputStreamReader;


public class ClashOfClan {

	private static String[] units = {"Barbarians ", "Archers ", "Giants ", "Goblins ", "Wall Breakers ", "Balloons ", "Wizards ", "Healers ", "Dragons ", "Pekka "};
	private static int[] elixirCost = {100, 200, 2250, 100, 3000, 4000, 3500, 8000, 30000, 35000};
	static int counter = 0;
	static String zero = "0";
	static int value = 0;

	public static void main(String[] args) {

		System.out.println("How many.... ");	
		finalValue();
		System.out.println("Total elixir used: " + value);

	}

	private static void finalValue() {
		for (int i = 0; i < units.length; i++) {
			value += totalCost();
		}
	}

	private static int convertInput() {
		String unit = checkUnit();
		String input = getInput(unit);
		if (input.isEmpty()) {
			input = zero;
		}
		int convertInput = Integer.parseInt(input);
		return convertInput;
		
	}

	private static int totalCost() {
		int addingCost = convertInput();
		int totalCost = addingCost * elixirCost[counter];
		counter++;
		return totalCost;
	}
	
	private static String checkUnit() {
		String unit = units[counter];
		return unit;
	}
	
	private static String getInput(String prompt) {
		BufferedReader stdin = new BufferedReader(
				new InputStreamReader(System.in));

		System.out.print(prompt);
		System.out.flush();
		
		try {
			return stdin.readLine();
		} catch (Exception e) {
			return "Error: " + e.getMessage();
		}
	}
}

[jim829]

Get rid of your static methods and variables for one. If units and elixarCosts are related, why not combine them in a class? And it seems like some of your methods are gratuitous. For example, you only call checkUnit() and getInput() at one location. So why use methods?

Regards,
Jim

[Juan2114]

Is quite a bare bones class, so not much to do, maybe an Unit class that holds (name, price), as i said not much to look at so yea.

[DarrylBurke]

Looks like I’m doing procedural programming

Also looks like you're cross posting.

first program in Java, how to make it less procedural and more OOP (Beginning Java forum at JavaRanch)

db