little test program, any opinions or feedback?

[Jason8BMX]

import java.util.Scanner;
public class test{
	public static void main(String[] args){
		String username;
		String signup;
		String setup;
		String email;
		String pssword;
		final int length = 6;
		final int length2 = 8;
		Scanner input = new Scanner(System.in);
		setup = ("Welcome to Test.net");
				System.out.println(setup);
				signup = ("Please enter your email to get started:");
						System.out.println(signup);
						email = input.next();
						while (email.length() < length2){
							System.out.println("this is not a valid email");
							email = input.next();
						}
						System.out.println("now your username");
						username = input.next();
						while (username.length() < length){
							System.out.println("your username needs to be more than 6 letters");
							username = input.next();
						}
						System.out.println("now your password");
						pssword = input.next();
						while (pssword.length() < length){
							System.out.println("your password needs to be more than 6 letters long, please enter it again");
							pssword = input.next();
						}
				System.out.println("Here are your account details:");
				System.out.println("username: " + username);
				System.out.println("password: " + pssword);
				System.out.println("email: " + email);

This is the code from one of my test projects. I am starting to program and chose to learn java. Please let me know if I can improve on anything or if this is a good program for just a few days of java. Thanks!

[JosAH]

A few remarks: why are you doing this:

variable= ("a String literal value");

instead of simply this:

variable= "a String literal value";

Also, your indentation style is confusing.

kind regards,

Jos

[Monte]

if you work with passwords, you could consider using hashes, because save a password as cleartext in a string is not very secure^^ (but i should notice i have no experience with that..)

[gimbal2]

if you work with passwords, you could consider using hashes, because save a password as cleartext in a string is not very secure^^ (but i should notice i have no experience with that..)

Well then you might be interested in this awesome article:

https://crackstation.net/hashing-security.htm

[KevinWorkman]

You haven't told us what this program is supposed to do, and you don't include any comments. This makes it harder for people who have to work with your code (namely us). You should get into the habit of either using comments, or always including an explanation of code when you post it.

You should also use standard naming conventions- classes start with an upper-case letter, methods and variables with a lower-case letter. This also helps other people understand your code.

Like Jos said, your indentation is confusing. Again, this makes it harder for other people to understand your code.

You might consider creating a method that takes parameters for the different messages, maybe use an Account object to encapsulate the data.

But really, if you're just starting out, I wouldn't worry too much about making sure your syntax is perfect. Does this program do what you want? Cool. Do you understand exactly how it works? Cool. Move on to the next thing.

No matter how perfectly you write your code now, it's going to look like garbage to you in 6 months. This is a sign of your improvement, and will stay with you for the rest of your programming career. You're much better off spending your time trying the next thing out than trying to write perfect code.