Trying to initialize arrays

[supremegrandruler]

Alright, noob question. I've search on multiple sites but can't figure what's wrong. I've tried writing things a billion different ways. I'm making a card game and have a class I used to assign all my card variables.
However, it's giving me multiple errors and I can't seem to be able to access the variables from my other classes.

package com.summoners.Screen;

class Cards {
    public static String[] names;

        name = new String[1000];
        atk = new int[1000];
           
        // initialize card data
        name[0] = "John";
        atk[0] = 30;
        
        name[1] = "Bob";
        atk[1] = 2;
        
        name[2] = "Mark";
        atk[2] = 5;
    
    }
}

[gimbal2]

No method anywhere. That's all I'm going to say.

[jim829]

This shouldn't even compile. names vs name.

Regards,
Jim

[JosAH]

... and those parallel arrays are not done; even a single array is so Fortranesque ...

kind regards,

Jos

[supremegrandruler]

I (think I) fixed it. Thanks guys.

package com.summoners.Screen;

class Cards {
    public static String[] name;
    public static int[] atk;

    public static void initCardData(){
        name = new String[1000];
        atk = new int[1000];
           
        // initialize card data
        name[0] = "John";
        atk[0] = 30;
        
        name[1] = "Bob";
        atk[1] = 2;
        
        name[2] = "Mark";
        atk[2] = 5;
    }   
}

[gimbal2]

Well at least it will compile, but it isn't fixed until you know how to remove all those static keywords and you use only one array and a class to store the two pieces of data per index.

[supremegrandruler]

Well at least it will compile, but it isn't fixed until you know how to remove all those static keywords and you use only one array and a class to store the two pieces of data per index.

I don't know how to use getters & setters with arrays. :(

[gimbal2]

Apparently that does not trigger you to go learn. That is a situation I hope that will resolve itself sooner rather than later, at this point you should be driven by a quest for knowledge and understanding and not to "make stuff work".

[JosAH]

I don't know how to use getters & setters with arrays. :(

Neither do I because arrays don't have methods; putting the same old gibberish (read: non-OO stuff) in a main( ... ) method doesn't instantly make your code 'elegant' code. Define a small class and stick objects of that class in a List and forget about those parallel arrays and forget about arrays all together; it'll make your code so much more flexible.

kind regards,

Jos

[kneitzel]

Just to explain in more detail how you could build up your application in an object oriented way. (Please be aware that this is a little guessing because you didn't give any details so far):

Your game has Player which have a Name and a "atk" value. (And maybe even more. Maybe your cardgame can run multiple games so it has a reference to a game instance the player is playing / part of.).
So you can create a class Player with these fields inside.
Your game holds a List of Players (Or maybe again your 100 but that only makes sense when you want to have exactly 100 Player). So you can get a List<Player> in which you store your player objects.

You create objects like that. Maybe you have some kind of Gameboard on which cards can be placed. In such a case you can have a Gameboard class or something like that.

Whenever you need to implement something, then you put it, where it really belongs to. So for example: A player can draw a card. This could be the function "DrawCard()".

Did this help a little bit? Or do you need more help regarding such an object oriented design? In such a case you might want to give us details what you have in mind and we might give you suggestions how it could be done.

With kind regards,

Konrad

[supremegrandruler]

Just to explain in more detail how you could build up your application in an object oriented way. (Please be aware that this is a little guessing because you didn't give any details so far):

Your game has Player which have a Name and a "atk" value. (And maybe even more. Maybe your cardgame can run multiple games so it has a reference to a game instance the player is playing / part of.).
So you can create a class Player with these fields inside.
Your game holds a List of Players (Or maybe again your 100 but that only makes sense when you want to have exactly 100 Player). So you can get a List<Player> in which you store your player objects.

You create objects like that. Maybe you have some kind of Gameboard on which cards can be placed. In such a case you can have a Gameboard class or something like that.

Whenever you need to implement something, then you put it, where it really belongs to. So for example: A player can draw a card. This could be the function "DrawCard()".

Did this help a little bit? Or do you need more help regarding such an object oriented design? In such a case you might want to give us details what you have in mind and we might give you suggestions how it could be done.

With kind regards,

Konrad

Thanks, very useful. I'm used to modding for WarCraft III so that's how we've always done it. I'm beginning to think a lot more in OO ways and studying from a quite a few different sources, including the Java website.

Thanks, you guys are very helpful. :)