Accessing an object created in another class

[kkid]

This is a pretty basic question but I don't know whether it is genuinely a problem or if my mind has just gone blank.


I have a situation where I have 2 classes and an array of objects which are causing me trouble.

The object type is one I have created - it is made from a class which is neither of the 2 classes I previously mentioned.

The array is created and occupied in Class1 and the problem arises when I try to reference one of the element from Class2.

At first I forgot the the array would be local to Class1.main so I made the array a global variable using:

public MyObjectType[] myArray;

Then I tried accessing an element (2) from Class2 using:

Class1.myArray[2]

However I get errors saying that I can't access the static variable from a non-static context.
I understand a little bit about static and non-static objects/methods but don't know how to fix this. Do I need to include "static" in the array declaration?

[Norm]

If the variable: myArray exists in an instance of the Class1 class, then to access it you need a variable that references an instance of the Class1 class. Often getter methods are used for that.

Class1 cls1Ref = new Class1();  //  create an instance and set a reference variable
 ...
aVar = cls1Ref.getTheVar(idx);     //  call the method to get the value

[kkid]

Probably should have mentioned this. Class1 is my main class. I can't make an instance of it (right?)

[Norm]

No, you should be able to create an instance of the Class1 class.

[kkid]

ok, I'll give it a shot.

It is the array that should be a global variable, right?
I shouldn't be making seperate global variables for each element i.e. myArray[0], myArray[1] etc...?

[kkid]

Where is it I am creating the instance?
In Class2?

I'm getting confused about making an instance of class 1 (Which doesn't even have a constructor). Won't this be duplicating all of the actions of class1?

[Norm]

Sorry, I don't understand what you are saying.
Can you post code the compiles, executes and shows the problem?

[kkid]

I've removed all unnecessary code and generalised it.

Here are the 3 classes:

public class Class1{

	public myObject[] array;

	public static void main(String[] args){
		
		array = new myObject[3];
		for(int i = 0; i < 3; i++){
			array[i] = new myObject(i);
		}
	}
}

class myObject{

	int indexNumber;

	public myObject(int iN){
		indexNumber = iN;
	}
}

class Class2{

	int indexNumber;
	myObject associatedMyObject;

	public Class2(int iN){
		indexNumber = iN;
		associatedMyObject = associatedMyObject();
	}
	
	private myObject associatedMyObject(){
		if(indexNumber == 0 || indexNumber == 5){
			return Main.array[2];    // The issue occurs here
		}
		else if(indexNumber == 1 || indexNumber == 2){
			return Main.array[0];   // And here
		}
		else{
		 return Main.array[1];    // And here
		}
	
	}
	
	
}

[Norm]

Does that code compile?

[kkid]

Does that code compile?

No, because of the static issue.

It should otherwise though (It was working until I added the related parts into the program).

(Also missed out a } originally, fixed now)

[exonaut]

No, because of the static issue.

It should otherwise though (It was working until I added the related parts into the program).

(Also missed out a } originally, fixed now)

So do you have any other problems?

[kkid]

So do you have any other problems?

No, this is it.

[Norm]

No, because of the static issue.

The main() method should create an instance of the Class1 class. The Class1 class's constructor should create and fill the array.

[kkid]

I'm sorry. I made a mistake with the generalisation. Main is the Class1 I mentioned earlier. I'll just change that in the code now.
Unless you do in fact mean for me to use a class to create an instance of itself?

[Norm]

The main() method can create an instance of the Class1 class.

[kkid]

The main() method can create an instance of the Class1 class.

Oh right, I didn't realise, sorry. I'll give it a go.

[kkid]

I've attempted what you said - I created an instance of Class1 in main and shifted the rest over to the constructor.

However now it has just shifted the same problem over to the line "Main = new Class1();". Main is not in a static location and the reference to it is

public class Class1{

	public myObject[] array;
	public Class1 Main;

	public static void main(String[] args){
	
		Main = new Class1();
		
	}

	public Class1{
		
		array = new myObject[3];
		for(int i = 0; i < 3; i++){
			array[i] = new myObject(i);
		}

                Class2[] class2 = new Class2[6];
		for(int i = 0; i < 6; i++){
			class2[i] = new Class2(i);
		}
	}
}

class myObject{

	int indexNumber;

	public myObject(int iN){
		indexNumber = iN;
	}
}

class Class2{

	int indexNumber;
	myObject associatedMyObject;

	public Class2(int iN){
		indexNumber = iN;
		associatedMyObject = associatedMyObject();
	}
	
	private myObject associatedMyObject(){
		if(indexNumber == 0 || indexNumber == 5){
			return Main.array[2];    // The issue occurs here
		}
		else if(indexNumber == 1 || indexNumber == 2){
			return Main.array[0];   // And here
		}
		else{
		 return Main.array[1];    // And here
		}
	
	}
	
	
}

[Norm]

Why is the variable: Main a class instance variable? It can be a local variable in main()
How/where is an instance of Class2 create? When it is created can a reference to the instance of Class1 be passed to it?

Some questions on the design:
Who creates instances of Class1 and Class2?
Why is there a main() method in Class1? Normally main() methods are where execution for a program is started.

[kkid]

Accidentally removed the Class2 instantiation when simplifying, sorry. Added it in now.

Class1 is only meant to be my main class which I am using to instantiate other class and actually perform the program calling subroutines from other classes to do the work. Hence why it has a main method. I am using javac Class1.java and java Class1 when I use the program for real.

Hence, nobody creates instances of Class1, it is Class1 who creates instances. Hence why I was confused when you said for me to create instances of Class1 using Class1 itself.

Main is a class instance variable simply because I'm confused - I thought the point of creating this instance was to have something non-static to reference from another class and hence it would need to be a global variable to be visible outside of the main() method.

[Norm]

What is Class2 for? Who uses it?

What class needs access to the contents of array? If other classes need to get to it, provide getter and setter methods in the Class1 class.