incompatible types

[XNOViiCE]

Hello all, I have been trying to get this to work for some time and I just don't know what I am doing wrong.

The problem I am having is that I am trying to get the method plus to return a TVector number so when the Object in the other class receives it the toString method can be called and work properly. Also the array "vect" has to be long.

Could anyone give any advice on how I would get this to work?

public class TVector 
{
   private static final int N = 4;
   private long [] vect = new long[N];
   public TVector ( String s )
   {
      String[] tokens = s.split("[(),]");
      vect = new long[N];
      for(int i = 0; i < N; i++)
      {
         vect[i] = Integer.parseInt(tokens[i+1]);
      }
   }
    
   public TVector(TVector v)
   {
    vect = v.vect;  
   }
   
   public TVector plus ( TVector adding )
   {
      TVector [] total = new TVector[N];
      
      for (int i = 0; i < N; i++)
      {
         total[i] = vect[i] + adding.vect[i];
      }
      return total;
   }

...

 @Override
   public String toString()
   {
      String Prod;
      String finalProd = String.format("(");
      for(int i = 0; i < N - 1; i++)
      {
         Prod = String.format( vect[i] + ",");
         finalProd = finalProd + Prod;
      }
      Prod = ( vect[N - 1] + ")");
      finalProd = finalProd + Prod;
      return finalProd;
   }
}

if (obj1 instanceof TVector && obj2 instanceof TVector)
      {
        //This has to compute the sum of obj1 and obj2 as TVector and assign the sum to obj
         TVector v1;
         v1 = (TVector)obj1;
         obj = v1;
         obj = v1.plus((TVector)obj2);
         
         System.out.println("The sum of obj1 and obj2: " + obj.toString());

[jim829]

Your plus method return is declared to return a single TVector instance. However, you are returning an array of TVectors. So the return type
in the method signature needs to be TVector[].

The other problem is the following:

total[i] = vect[i] + adding.vect[i];

total is an array of type TVector[]. You can't simply add two longs together and store them directly in a TVector[] array. You would need to do something like the following:

total[i].total = vect[i] + adding.vect[i]

where total is a field in the TVector class and is of type long.

Regards,
Jim

[XNOViiCE]

Thank you so much for replying! I don't totally understand what you mean by the "total[i].total" part though. Do you mean that "total[i]" is still a TVector array and the ".total" is a type long?

[jim829]

Yes! TVector is a class which you made to represent some element. You cannot assign a long directly to a TVector anymore than you can assign a String type to an int. And since Java does not allow user defined operator overloading, you can't add two TVectors together either. So you are clearly wanting to add two longs together. Perhaps what you really want is the following:

public TVector plus ( TVector adding )   {
      TVector total = new TVector();
       
      for (int i = 0; i < N; i++)
      {
         total.vect[i] = vect[i] + adding.vect[i];
      }
      return total;
   }

Regards,
Jim

[XNOViiCE]

Oh! I understand what you are doing. With the "new TVector();" that will require a new constructor?

[XNOViiCE]

I got it, never mind about that last question. Thank you for all your help!

For reference and to see what I did.

public TVector plus ( TVector adding )
   {
      TVector total = new TVector(this); //copy constructor because we were required to have only those two constructors
      
      for (int i = 0; i < N; i++)
      {
         total.vect[i] = vect[i] + adding.vect[i];
      }
      return total;
   }

[jim829]

Yes. Create an empty TVector. I am guessing you just want to pass one TVector instance to another and it to the current TVector and return a new TVector. Like this:

TVector sum = currentTVector.plus(someOtherTVector);

BTW, did you know you can use a variable length field for populating your TVector of arbitrary length?

public class TVector {
   private long[] vect;
   public TVector(long...myLongs) {
      vect = new long[myLong.length];
      for ( int j = 0; j < myLongs.length; j++) {
         vect[j] = myLongs[j];
      }
  }
}

Then you can do this:

TVector t = new TVector(1,2,3,4,5,6,19,192,39);

In your case it might complicate things since it depends on the argument to declare the array size. But you could modify it to use a fixed length array
like you did earlier, where N = 4. The point is it makes it easy to pass and fill an array without parsing a String argument.

Regards,
Jim

[XNOViiCE]

I didn't know that. Thank you for the tip! I will certainty use that in the future.