Sorting Elements From a File

[Zelaine]

Hello!

I put some names and scores into a file called "hej.txt", like this:

Random1
10
Random2
20
Random3
30
etc.

Then I made a program that read the contents of the file and output the biggest score and the name of the person who performed the score. However, my program doesn't seem to sort the scores, since they're in the same order as they were before sorting. Do you know why this happens, and how to get it working? This is my code:

import java.util.Scanner;
import java.io.*;

public class Ostbågar{
    public static void main(String[] args){
        File file = new File("hej.txt");
        try{
            Scanner hej = new Scanner(file);
            int rader = 0;
            while(hej.hasNext()){
                String s = hej.nextLine();
                if(s == null)
                    break;
                rader++;
            }
            hej = new Scanner(file);
            if(rader > 1 && rader % 2 == 0){
                String namn[] = new String[rader/2];
                int scores[] = new int[rader/2], x = 0, y = 0;
                while(hej.hasNext()){
                    String s = hej.nextLine();
                    if(s == null)
                        break;
                    namn[x] = s;
                    s = hej.nextLine();
                    scores[y] = Integer.parseInt(s);
                    x++; y++;
                }
                while(x<(scores.length-1)){
                    for(y=0;y<scores.length-1;y++){ // SORTING THE ELEMENTS HERE!
                        if(scores[y] < scores[y+1]){
                            int temp = scores[y];
                            scores[y] = scores[y+1];
                            scores[y+1] = temp;
                            String grej = namn[y];
                            namn[y] = namn[y+1];
                            namn[y+1] = grej;
                        }
                    }
                    x++;
                }
                System.out.print(namn[0] + " had the highest score with " + scores[0] + "!");
            }else
                System.out.print("Error reading file!");
        }catch(FileNotFoundException e){  
        }
    }
}

[jim829]

I'm not certain I understand. How do you know your sort doesn't work if you already put them in sorted order? Or am I not understanding something?

Edit: Ok, after looking at your code, you need to reset x to 0 before your while statement of your sort loop.

Regards,
Jim

[Zelaine]

Oh, of course, how did I not see that? Thanks :)