having some issues with nested loops. keeps resetting values and wont work properly.

[barqcider]

i know im missing something here and well, i THINK this is what he expects us to do for this program. i'm not sure though, however im running into an issue where the total deposit resets to 1000. earlier on, i had it where if i put -1 to exit, it did but if i typed in 200 for withdraw, it went into an infinite loop.

any ideas?

import java.util.Scanner;
public class BankAccount {

	/**
	 * @param args
	 */
	public static void main(String[] args) {
		// TODO Auto-generated method stub
		Scanner in= new Scanner(System.in); // reads in user input
		String accountStatus="Active"; //state of activity for account
		double acctBalance= 1000; //fixed account balance
		double withdrawAmt = 0; // user input to amount withdrawn
		double newBalance = acctBalance-withdrawAmt; // for the new balance after subtracting the withdraw from the account balance
		 do{
			System.out.print ("enter withdrawl amount. type -1 to exit: ");
			withdrawAmt= in.nextDouble();
			newBalance--;
			newBalance= acctBalance-withdrawAmt; //new account balance after withdraw
		 if (accountStatus.equals("Active")&&(acctBalance>=withdrawAmt)){/* checking to see if account is active and withdraw ammount
		 is equal to or less than the current balance */
			 System.out.println("your new balance is : "+ newBalance); // If true, this shows the new balance in the account
		 }
		 else{
			 System.out.println("insufficient funds"); // prints if the withdraw amount is greater then the account balance.
		 }
		 }
		 while
			 (newBalance >=0|| withdrawAmt!=-1);
		 System.out.println("your new balance is : "+ newBalance);
			 
			
	
		
		 
	}

}// end main

[barqcider]

it keeps either looping back to the original balance of 1000 instead of decreasing each time i withdraw. it also doesnt exit if i type -1 and keeps adding 1 to the balance.
any pointers?

[Norm]

When using an OR with multiple conditions, if ANY of the sub conditions are true, the whole expression is true.
If you used an AND, then ALL of the conditions would have to be true for the whole expression to be true.

Look at the conditions tested in the while().

[barqcider]

i removed the || and simply made it !=-1, but it keeps adding 1 and not deducting.

i was testing it so i can get to $0 and get the insufficient funds message, but it only restarts to 1000. even if i put -1, it doesnt kick out.

[jim829]

There are several problems. First, why do you have a newBalance variable? You don't need it from what I can tell. Remove the newBalance-- statement and change all the other newBalance variables to acctBalance.

The other problem is that when you use -1 to signal the end of the session, you process it as a valid amount. It doesn't hit the while condition till the end. So you need to check for -1 as soon as it is entered and take action immediately.

Regards,
Jim