Pinging an IP adress that is taken from a TextField.

[MR bruto]

hey.
im making a program with different sorts of buttons and textfields, to execute commands in the command prompt. (such as ping, ipconfig, and more).

im kinda stuck on the ping option.

i have a JTextField where the user has to fill in an IP adress to ping.
then i save that ip adress in a string and i tried to make a command out of that.
check out how i did it below:

	JButton btnNewButton_7 = new JButton("Ping -->");
		btnNewButton_7.addActionListener(new ActionListener() {
			public void actionPerformed(ActionEvent e) {
				try{
				    
					String ipadd = textField_1.getText();
					Process p = Runtime.getRuntime().exec("cmd /c ping"+ipadd);
					BufferedReader reader = new BufferedReader(new InputStreamReader(p.getInputStream()));
					String line = reader.readLine();
					
					while(line != null){
						textArea.append(line+"\n");
						line = reader.readLine();
					}
				
					}catch(IOException e3){}
			}
		});
		btnNewButton_7.setBounds(221, 154, 107, 31);
		getContentPane().add(btnNewButton_7);

but when i click the button it doesnt do anything at all.

i know that i cant put a string on that process, but i don't know any other way i could do this.

so what i want: user filling in an ip adress in the textfield, then i want to make the command ping the filled in ip adress.

any solutions?

Thanks

[gimbal2]

Check out this epic article:

When Runtime.exec() won't - JavaWorld

And you will want to do the actual ping in a separate thread; you don't want the action listener to be on hold while the ping command is doing its thing, it runs on the EDT and so will block the EDT. That is most likely the reason why you don't "see" anything happening.

[JosAH]

	Process p = Runtime.getRuntime().exec("cmd /c ping"+ipadd);

Also put a space between the 'ping' command and the IP address.

Jos

[gimbal2]

Doh! Nice catch.

[JosAH]

Doh! Nice catch.

I guess the code will run (sort of) fine as is; except for the output in the JTextArea; it will only be displayed when the ping command has finished and the ActionListener has finished as well, so your hint most certainly shouldn't be ignored.

kind regards,

Jos

[MR bruto]

Check out this epic article:

When Runtime.exec() won't - JavaWorld

And you will want to do the actual ping in a separate thread; you don't want the action listener to be on hold while the ping command is doing its thing, it runs on the EDT and so will block the EDT. That is most likely the reason why you don't "see" anything happening.

Thanks man! i fixed it!