calculator-Switch not invoked

[sami205]

Hi dear friends I am making my class assignment to make a basic calculator,in which the user can give value in run time and can select the function which he/she want to perform. My code is given below

//Simple calculator.
import javax.swing.*;
class calculator{
  int val1;
  int val2;
  int choice;
}
class cal{
  public static void main(String args[]){
    calculator x;
    x=new calculator();
        
 String abc=JOptionPane.showInputDialog(null, " Insert value 1");
 String def=JOptionPane.showInputDialog(null, " Insert Value 2");
 String op="Select the choice:\n 1 for Addition.\n 2 for subtraction.\n 3 for multiplication.\n 4 for division.";
 String ghi=JOptionPane.showInputDialog(null, op);
 x.val1=Integer.parseInt(abc);
 x.val2=Integer.parseInt(def);
 x.choice=Integer.parseInt(op);
 switch(x.choice){
   case 1:
 int s;
 s=x.val1+x.val2;
 JOptionPane.showMessageDialog(null, "Total Sum is= "+s);
  break;
   case 2:
 int multi;
 multi=x.val1*x.val2;
 JOptionPane.showMessageDialog(null, "Multiplication ans= "+multi);
  break;
   case 3:
 int div;
 div=x.val1/x.val2;
 JOptionPane.showMessageDialog(null, "Division ans= "+div);
 break;
   default:
    JOptionPane.showMessageDialog(null, "invalid choice"); 
 }
  }
}

when I run this program only Input dialogbox open and take values from me but not performed any function as all function written in switch statements and its not invoked please help me where I did something wrong in this code or what is missing in this code?
Please reply quickly.

[Jingoism]

Let me fix that coding first.. hard to look at.

//Simple calculator.
import javax.swing.*;
class calculator{
	int val1;
	int val2;
	int choice;
}
class cal{
	public static void main(String args[]){
		calculator x;
		x=new calculator();

		String abc=JOptionPane.showInputDialog(null, " Insert value 1");
		String def=JOptionPane.showInputDialog(null, " Insert Value 2");
		String op="Select the choice:\n 1 for Addition.\n 2 for subtraction.\n 3 for multiplication.\n 4 for division.";
		String ghi=JOptionPane.showInputDialog(null, op);
		x.val1=Integer.parseInt(abc);
		x.val2=Integer.parseInt(def);
		x.choice=Integer.parseInt(op);
		switch(x.choice){
		case 1:
			int s;
			s=x.val1+x.val2;
			JOptionPane.showMessageDialog(null, "Total Sum is= "+s);
			break;
		case 2:
			int multi;
			multi=x.val1*x.val2;
			JOptionPane.showMessageDialog(null, "Multiplication ans= "+multi);
			break;
		case 3:
			int div;
			div=x.val1/x.val2;
			JOptionPane.showMessageDialog(null, "Division ans= "+div);
			break;
		default:
			JOptionPane.showMessageDialog(null, "invalid choice"); 
		}
	}
}

Problem is here:

String ghi=JOptionPane.showInputDialog(null, op);

Replace op with ghi and you are gold.

x.choice=Integer.parseInt(ghi);

You just got a bit backward on which var to use.

[sami205]

Thanks for reply Friend.

I did what you suggest to do with this code but it does not compile and mark a new issue, Please check it again practically I shall be very thankful to you.

[sami205]

OH Thanks God I got solution and Now the fully function code is

//Simple calculator.
import javax.swing.*;
class calculator{
  int val1;
  int val2;
  int choice;
  
}
class cal{
  public static void main(String args[]){
    calculator x;
    x=new calculator();
         
 String abc=JOptionPane.showInputDialog(null, " Insert value 1");
 String def=JOptionPane.showInputDialog(null, " Insert Value 2");
 String op="Select the choice:\n 1 for Addition.\n 2 for subtraction.\n 3 for multiplication.\n 4 for division.";
 String ghi="0";
   ghi=JOptionPane.showInputDialog(op, ghi);
 x.val1=Integer.parseInt(abc);
 x.val2=Integer.parseInt(def);
 x.choice=Integer.parseInt(ghi);
 switch(x.choice){
   case 1:
 int a;
 a=x.val1+x.val2;
 JOptionPane.showMessageDialog(null, "The Sum is= "+a);
  break;
   case 2:
  int s;
 s=x.val1-x.val2;
 JOptionPane.showMessageDialog(null, "The subtraction is= "+s);
  break;
     case 3:
 int m;
 m=x.val1*x.val2;
 JOptionPane.showMessageDialog(null, "The Multiplication is= "+m);
  break;
   case 4:
 int d;
 d=x.val1/x.val2;
 JOptionPane.showMessageDialog(null, "The Division is= "+d);
 break;
   default:
    JOptionPane.showMessageDialog(null, "invalid choice");
 }
  }
}

[Jingoism]

What error did you get? I just pasted the code you had up top, and replaced the "op" with "ghi" and it ran perfectly.

String javax.swing.JOptionPane.showInputDialog(Component parentComponent, Object message)... I guess it works, and that is all that matters.