For loop not working properly

[phyzix5761]

I'm working with lwjgl. I have a for loop that is supposed to iterate between boxes I've created but once the keyboard event takes place it only iterates through the first box created. How can I get it to iterate through each box? Here is the code that is giving me problems:

while(!Display.isCloseRequested())
        {
            glClear(GL_COLOR_BUFFER_BIT);
            
            while(Keyboard.next())
            {
                if(Keyboard.getEventKey() == Keyboard.KEY_C &&
                        Keyboard.getEventKeyState())
                {
                    shapes.add(new Box(Mouse.getX()-25, 480 - Mouse.getY()-25));
                }
            }
            
            if(Keyboard.isKeyDown(Keyboard.KEY_ESCAPE))
            {
                Display.destroy();
                System.exit(0);
            }
            
            for(Box box : shapes) 
            {
                if(Mouse.isButtonDown(0) && !somethingIsSelected) 
                {
                    
                    somethingIsSelected = true;
                    
                        if(box.inBounds(Mouse.getX(), 480 - Mouse.getY()))
                        {
                            box.selected = true;
                        }
                   
                    
                }
                
                if(!Mouse.isButtonDown(0) && somethingIsSelected)
                {
                    System.out.println(box);
                    box.selected = false;
                    somethingIsSelected = false;
                }
                
                if(box.selected)
                {
                    box.update(Mouse.getDX(), Mouse.getDY());
                }
                
                    
                box.draw();
            }
         
            
            //int mousey = 480 - Mouse.getY()-1;
            //int xvelocity = Mouse.getDX();
            //int yvelocity = -Mouse.getDY();// must make oposite 
            
           // System.out.println(xvelocity+" "+yvelocity);
                        
            Display.update();//update window
            Display.sync(60);//sync to 60 fps
        }

[quad64bit]

Are you sure that all your boxes are present in your shapes collection? Are you sure the for loop isn't looping through them all but only applying changes the the first one? Put a System.out.println in that loop and see how many times it actually loops.

[phyzix5761]

I know it loops through all the boxes until it gets to this statement:

if(Mouse.isButtonDown(0) && !somethingIsSelected) 
                {
                     
                    somethingIsSelected = true;
                     
                        if(box.inBounds(Mouse.getX(), 480 - Mouse.getY()))
                        {
                            box.selected = true;
                        }
                    
                     
                }

There it stops looping for some reason. But outside that statement it is still looping. It's weird.

[pbrockway2]

outside that statement it is still looping.

I'm not sure what that means.

If you mean that the body of the if statement doesn't get executed then that's because the condition "Mouse.isButtonDown(0) && !somethingIsSelected" is false.

As well as using System.out.println() to see how many times you go around the loop you can also use it to print the things that determine the behaviour inside the loop: box, Mouse.isButtonDown(0), somethingIsSelected, and box.selected. This is best done at the start of the loop.

[phyzix5761]

Let me show you what I mean. (Check comments in code).

for(Box box : shapes) 
            {
                System.out.println(box);//this shows that it loops through every box
                if(Mouse.isButtonDown(0) && !somethingIsSelected) 
                {
                    System.out.println(box);//this shows that it only loops through the 1st
                    somethingIsSelected = true;
                     
                        if(box.inBounds(Mouse.getX(), 480 - Mouse.getY()))
                        {
                            box.selected = true;
                        }
                    
                     
                }
                 
                if(!Mouse.isButtonDown(0) && somethingIsSelected)
                {
                    System.out.println(box);
                    box.selected = false;
                    somethingIsSelected = false;
                }
                 
                if(box.selected)
                {
                    box.update(Mouse.getDX(), Mouse.getDY());
                }
                 
                     
                box.draw();
            }

[pbrockway2]

Have a look at the state each time around the loop:

for(Box box : shapes) 
{
    System.out.println("Entered loop with box=" + box);
    System.out.println("Mouse down=" + Mouse.isButtonDown(0));
    System.out.println("somethingIsSelected=" + somethingIsSelected + " box.selected=" + box.selected);
    if(Mouse.isButtonDown(0) && !somethingIsSelected) 
    {
        // etc

Remember that nothing in the first if statement (eg the second printin() you have) will execute if Mouse.isButtonDown(0) is false or somethingIsSelected is false. Based on what you've posted both of these are capable of changing from one loop iteration to the next - hence the need to print them out each time.