A java problem for you

[subzero1012]

Hello,
I wanted to see how others would have solved the following problem.

Create an array of 5 Strings containing people's names. Write a program that counts and displays the total number of vowels in the array.

Here's how I did it.

public class Vowels{
   public static void main(String[] args){
	   String[] names = {"Rob", "Tom", "Dad", "Mom", "Sharon"};
		int vowelCount = 0;
		for(int i = 0; i < names.length; i++){
		   for(int j = 0; j < names[i].length(); j++){ 
			   if(names[i].substring(j,j+1).equals("a") ||
				   names[i].substring(j,j+1).equals("e") ||
					names[i].substring(j,j+1).equals("i") ||
					names[i].substring(j,j+1).equals("o") ||
					names[i].substring(j,j+1).equals("u"))
					vowelCount = vowelCount + 1;
			   /*System.out.println(names[i].substring(j,j+1));*/
			}
		}
		System.out.println(vowelCount);
	
	}
}

[DarrylBurke]

Please go through the Forum Rules -- particularly the third paragraph.

db

[pbrockway2]

I'd use charAt() and the expressive idiom "whatever".indexOf(someChar). Both are String methods.

I'd also ask for clarification from whoever posed the problem concerning what to do with aunty Yvonne, cousin Jenny et al. (Although Al isn't really controversial.)

[Norm]

You do this 6 times
names[i].substring(j,j+1)
vs one time and use the results.

Indexing and substring are expensive and the repeated use of expressions leaves lots of room for coding errors.

[Ksharp]

How about this:

import java.util.Arrays;

 
public class JavaApplication23 {
 public static void main(String[] args){
       String[] names = {"Rob", "Tom", "Dad", "Mom", "Sharon"};
       int x=Arrays.toString(names).replaceAll("[^aAeEiIoOuU]","").length();
        
        System.out.println(x);
     
    }
}

Ksharp