Scanner not reading every character in a file?

[Brandonhspace]

So I'm making a new game and i need it to read a file in order to build the level your character will walk around in. I have it pretty much done, except it seems to only read half of the numbers in the text file. Why is this not working?

public class level extends JPanel{
private int[][] layout;

public level() throws IOException{
setPreferredSize(new Dimension(1000, 650));
layout = new int[20][13];

int i=0, j=0;
Scanner scan = new Scanner(new File("level.txt"));
while(scan.hasNext()){
if(scan.nextInt()==0){
i=0;
j++;
}
else{
layout[i][j] = scan.nextInt();
i++;
}
}
}

this is what's in the text file:
2 2 2 2 1 1 1 2 2 2 2 3 3 3 2 2 2 1 2 2 0
2 2 2 1 1 1 2 2 2 2 2 3 3 3 2 2 2 1 1 1 0
2 2 2 2 2 2 2 2 2 2 2 3 3 3 2 2 2 2 2 1 0
2 2 2 2 4 4 4 4 4 2 2 3 3 3 2 2 2 2 2 2 0
2 2 2 2 4 4 2 4 4 2 2 3 3 3 2 2 2 2 2 2 0
2 2 2 4 4 4 4 4 4 4 2 3 3 3 2 2 2 2 2 2 0
2 2 2 2 4 4 4 4 4 4 2 3 3 3 2 2 2 1 2 1 0
2 2 2 4 4 4 4 4 4 4 2 3 3 3 2 2 2 1 1 1 0
2 2 2 2 2 4 4 4 4 2 2 3 3 3 2 2 2 2 1 1 0
2 2 2 2 2 2 2 2 2 2 2 3 3 3 3 3 3 3 3 3 0
2 2 2 2 2 2 2 2 2 2 2 3 3 3 3 3 3 3 3 3 0
2 2 1 1 1 2 2 2 2 2 2 3 3 3 3 3 3 3 3 3 0
2 2 2 1 1 1 2 2 2 2 2 2 2 2 2 2 2 2 2 2 0

[doWhile]

It is reading all the numbers in the file...note how you are calling scanner.nextInt() twice - once when you check the conditional, and another time in the code when that conditional evaluates to false.

[Fubarable]

You are reading the scanner twice in the while loop, and ignoring the results from the first read -- inside of the if block.

Myself, I'd scan each line using hasNextLine() inside of a while loop, and then use a separate Scanner for each line in its own while loop, using hasNextInt(), and remembering to close each scanner when I'm done with it.

[Brandonhspace]

oooh thank you! I understand what's going on now. Here's my appended code, not a lot of change but it made it work:

import java.awt.*;
import java.io.*;
import java.util.*;
import javax.swing.*;

public class level extends JPanel{
private int[][] layout;

public level() throws IOException{
setPreferredSize(new Dimension(1000, 650));
layout = new int[20][13];

int i=0, j=0, nextInt = 0;
Scanner scan = new Scanner(new File("level.txt"));
while(scan.hasNext()){
nextInt = scan.nextInt();
if(nextInt==0){
i=0;
j++;
}
else{
layout[i][j] = nextInt;
i++;
}
}
}

[Fubarable]

A word of caution, always try to have your Scanner#hasNextXXX() method match your call to Scanner#nextXXX(). So in other words, if in the body of your while block you are extracting scan.nextInt(), in the while boolean condition, check for scan.hasNextInt(). Likewise before you extract scan.nextLine(), you check for scan.hasNextLine(), or if you will call scan.nextDouble() you first check for scan.hasNextDouble(), or if scan.next(), you first check for scan.hasNext(). This can protect you against some errors.

[DarrylBurke]

Forum Rules
http://www.java-forums.org/forum-gui...w-members.html
BB Code List - Java Programming Forum

db