I have this weird problem..

**saber210** · 08-13-2011, 03:31 PM

First of all, I want to put strings on my array.. My array size will be 27.. The data must have 6 " " and the rest will have "enemy".. But my problem when i shuffle the data on the array sometimes it consist of 5 " " or even 7 " "

The code is here:

Java Code:

String [] enemyPieces= new String[27];

for(int my = 0; my <= 26; my++){
                if(my < 6 ){
                    enemyPieces[my] = "";
                }else{
                    enemyPieces[my] = "enemy";}
            }

            for (int xy = 0; xy < enemyPieces.length ;xy++){
            int randomPosition = randomPos.nextInt(enemyPieces.length);
            String temp = enemyPieces[xy];
            enemyPieces[xy] = enemyPieces[randomPosition];
            enemyPieces[randomPosition] = temp;

            System.out.println("New:" +enemyPieces[xy]);
            }

I dont know what is the problem on my code.

**Fubarable** · 08-13-2011, 03:37 PM

Your array is fine, but the problem is here:

Java Code:

System.out.println("New:" +enemyPieces[xy]);

You're printing out the array position before the "shuffle" has completed which will give you false information. Instead check the array contents after your pseudo-shuffle by creating another for loop after your for loop above, and printing out all the array values in this for loop.

**saber210** · 08-13-2011, 03:40 PM

I just put that code to check the items on the array list.. But it is always same.. It produce sometimes five " " and sometimes seven " "..

**Fubarable** · 08-13-2011, 03:46 PM

Originally Posted by saber210

I just put that code to check the items on the array list.. But it is always same.. It produce sometimes five " " and sometimes seven " "..

Let's see the new code.

**saber210** · 08-13-2011, 03:48 PM

Here is the code:

Java Code:

            for(int my = 0; my <= 26; my++){
                if(my <= 5 ){
                    enemyPieces[my] = "";
                }else{
                    enemyPieces[my] = "enemy";}
            }

            for (int xy = 0; xy < enemyPieces.length ;xy++){
            int randomPosition = randomPos.nextInt(enemyPieces.length);
            String temp = enemyPieces[xy];
            enemyPieces[xy] = enemyPieces[randomPosition];
            enemyPieces[randomPosition] = temp;


            }

            for (int mi = 0; mi < enemyPieces.length ;mi++){
            System.out.println("New:" +enemyPieces[mi]);
            }

**JosAH** · 08-13-2011, 04:53 PM

Originally Posted by saber210

Here is the code:

Java Code:

            for(int my = 0; my <= 26; my++){
                if(my <= 5 ){
                    enemyPieces[my] = "";
                }else{
                    enemyPieces[my] = "enemy";}
            }

            for (int xy = 0; xy < enemyPieces.length ;xy++){
            int randomPosition = randomPos.nextInt(enemyPieces.length);
            String temp = enemyPieces[xy];
            enemyPieces[xy] = enemyPieces[randomPosition];
            enemyPieces[randomPosition] = temp;


            }

            for (int mi = 0; mi < enemyPieces.length ;mi++){
            System.out.println("New:" +enemyPieces[mi]);
            }

Your curly bracketing is goofy; closely inspect your own code; it should be similar to this:

Java Code:

for loop to fille your array
for loop to shuffle your array
for loop to print your array

Now your code seems to be like this:

Java Code:

for loop to fill your array
   for loop to shuffle your array
   for loop to print your array

kind regards

Jos

**Fubarable** · 08-13-2011, 04:53 PM

So to flesh out the program, are you telling me that this code gives you a variable number of array items that hold spaces?

Java Code:

import java.util.Random;

public class Foo001 {

   public static void main(String[] args) {
      String[] enemyPieces = new String[27];
      Random randomPos = new Random();
      for (int my = 0; my <= 26; my++) {
         if (my <= 5) {
            enemyPieces[my] = "";
         } else {
            enemyPieces[my] = "enemy";
         }
      }

      for (int xy = 0; xy < enemyPieces.length; xy++) {
         int randomPosition = randomPos.nextInt(enemyPieces.length);
         String temp = enemyPieces[xy];
         enemyPieces[xy] = enemyPieces[randomPosition];
         enemyPieces[randomPosition] = temp;

      }

      for (int mi = 0; mi < enemyPieces.length; mi++) {
         System.out.println("New:" + enemyPieces[mi]);

      }
   }
}

Are you 100% sure about that? I urge you to double and even triple check this.

**saber210** · 08-14-2011, 02:14 AM

I cannot understand what you are trying to say.. Any simpler explanations please? Thanks!

**JeffGrigg** · 08-14-2011, 04:48 AM

I think that JosAH did not see the closing bracket on this line:

Java Code:

                    enemyPieces[my] = "enemy";}

So I think I agree with Fubarable that the code you posted appears to work correctly every time.

**saber210** · 08-14-2011, 04:53 AM

On the first part of the code works fine.. It produce 6 blank spaces and the other 21 are enemies..

This is the first code:

Java Code:

            for(int my = 0; my <= 26; my++){
                if(my <= 5 ){
                    enemyPieces[my] = "";
                }else{
                    enemyPieces[my] = "enemy";}
            }

I think this is the problem.. Sometimes it produce 7 blank spaces or sometimes 5 blank spaces.. but it must be 6 blank spaces..

Java Code:

 for (int xy = 0; xy < 26 ;xy++){
            int randomPosition = randomPos.nextInt(enemyPieces.length);
            String temp = enemyPieces[xy];
            enemyPieces[xy] = enemyPieces[randomPosition];
            enemyPieces[randomPosition] = temp;


            }

ANy fix for this? Thank you..

**JeffGrigg** · 08-14-2011, 05:02 AM

I run this code:

Java Code:

import java.util.Random;

public class WeirdProblem {

	public static void main(String[] args) {
		String[] enemyPieces = new String[27];
		Random randomPos = new Random();

		for (int my = 0; my <= 26; my++) {
			if (my <= 5) {
				enemyPieces[my] = "";
			} else {
				enemyPieces[my] = "enemy";
			}
		}

		for (int xy = 0; xy < enemyPieces.length; xy++) {
			int randomPosition = randomPos.nextInt(enemyPieces.length);
			String temp = enemyPieces[xy];
			enemyPieces[xy] = enemyPieces[randomPosition];
			enemyPieces[randomPosition] = temp;
		}

		int empties = 0;
		for (int mi = 0; mi < enemyPieces.length; mi++) {
			System.out.println("New:" + enemyPieces[mi]);
			if ("".equals(enemyPieces[mi]))
				++empties;
		}
		System.out.println("Number of empty spaces: " + empties);
	}

}

I get this result:

Java Code:

New:
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:
New:
New:enemy
New:enemy
New:
New:
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:enemy
New:
New:enemy
New:enemy
Number of empty spaces: 6

I get "Number of empty spaces: 6" every time.

**saber210** · 08-14-2011, 05:29 AM

This if for board game which is 9 by 8 board and I used this code to display it..

Java Code:

        for(int i = 0; i <= 7; i++)
        {
            for(int i1 = 0; i1 <= 8; i1++)
            {
                if (i == 0){
                Board[i][i1].setText(enemyPieces[i1]);
                }else
                if (i == 1){
                Board[i][i1].setText(enemyPieces[i1+9]);
                }else
                if (i == 2){
                Board[i][i1].setText(enemyPieces[i1+17]);
                }
            }

        }

Is there any problem on this?

EDIT: I got it now,, the problem is on how i show the spaces and the enemies.. Thanks a lot.