Counting occurence of a word in file

[KAS]

I can't seem to get the current code to count all occurences of specified word in the file. It should display 10, but only counts 8. Any obvious reason why it doesnt do this properly?

import java.io.*;

class lestal {

    public static void main(String[] args) throws Exception {

        FileReader fil = new FileReader("d:\\lab9_3.txt");
        BufferedReader br = new BufferedReader(fil);
        StreamTokenizer st = new StreamTokenizer(br);

        
        String SearchFor = "Java", word = "";
        int input, counter = 0;
        
        while ((input = st.nextToken()) != StreamTokenizer.TT_EOF) {

            if ((input == StreamTokenizer.TT_WORD)) {
                word = st.sval;
            }
            if (word.compareTo(SearchFor) == 0) {
                System.out.println(st.sval);
                counter++;
            }
        }
        System.out.println("Fant ordet \"Java\" " + counter + " ganger.");
        fil.close();
    }
}

This is the source of which it is supposed to count: http://pastebin.com/P7UdF8g7

[Norm]

Try debugging the code by adding print statements to show what tokens are being read and what Strings are being compared. The output should show you where the problem is.

What does the input file contain?

[KAS]

Try debugging the code by adding print statements to show what tokens are being read and what Strings are being compared. The output should show you where the problem is.

What does the input file contain?

Input file is equal to the text here: Primitive Data Types The Java programming language is statically-typed, which m - Pastebin.com

[Norm]

How does the program work with other input?

[KAS]

If I just type "Java" 13 times in the same file(removing the rest), it counts all 13. So it seems the problem is located elsewhere.

[JosAH]

Input file is equal to the text here: Primitive Data Types The Java programming language is statically-typed, which m - Pastebin.com

There are more than 10 occurrances of the word "Java" in that file ...

kind regards,

Jos

[dlorde]

Just a reminder about StringTokenizer - the API docs say "StringTokenizer is a legacy class that is retained for compatibility reasons although its use is discouraged in new code. It is recommended that anyone seeking this functionality use the split method of String or the java.util.regex package instead."

For some reason they haven't deprecated it yet, but the sentiment is similar.

[KAS]

There are more than 10 occurrances of the word "Java" in that file ...

kind regards,

Jos

If you count in "java." yes there is, but there are 10 consisting of "Java".

[Norm]

So have you tried debugging it using print statements to see where the problem is?

[KAS]

So have you tried debugging it using print statements to see where the problem is?

It seems to skip here(marked in bold)

Primitive Data Types
The Java programming language is statically-typed, which means that all variables must first be declared before they can be used. This involves stating the variable's type and name, as you've already seen:

int gear = 1;

Doing so tells your program that a field named "gear" exists, holds numerical data, and has an initial value of "1". A variable's data type determines the values it may contain, plus the operations that may be performed on it. In addition to int, the Java programming language supports seven other primitive data types. A primitive type is predefined by the language and is named by a reserved keyword. Primitive values do not share state with other primitive values. The eight primitive data types supported by the Java programming language are:

byte: The byte data type is an 8-bit signed two's complement integer. It has a minimum value of -128 and a maximum value of 127 (inclusive). The byte data type can be useful for saving memory in large arrays, where the memory savings actually matters. They can also be used in place of int where their limits help to clarify your code; the fact that a variable's range is limited can serve as a form of documentation.

If I remove the ' it works just fine. Suggestions?

[masijade]

If the file will always be small simply read the entire file into a String and then use indexOf(String, int) in a loop with a increment variable.

[KAS]

Tried to write the code a bit different:

import java.io.*;

class OcccurenceCounter {

    public static void main(String[] args) throws Exception {

        FileReader fil = new FileReader("d:\\lab9_3.txt");
        BufferedReader br = new BufferedReader(fil);
        StreamTokenizer st = new StreamTokenizer(br);

        
        String SearchFor = "Java", word = "";
        int input, counter = 0;
        
        do{
            do{
            input = st.nextToken();            
            } while (input != StreamTokenizer.TT_WORD);
            word = st.sval;            
            if(word.matches(SearchFor)){
                System.out.println(word);
                counter++;                
            }
        } while (input != StreamTokenizer.TT_EOF);
        fil.close();
        
        System.out.println("Fant \"Java\" " + counter + " ganger.");
        
    }
}

It still seem to get stuck at the same spot.

[Norm]

There are many methods to call to control how StreamTokenizer works.
Like ordinaryChar or quoteChar.

Have you tried some of those?

[KAS]

It seems the StreamTokenizer is bugged somehow, so I'm trying to solve this in another way.

[JosAH]

It seems to skip here(marked in bold)

If I remove the ' it works just fine. Suggestions?

Yep, a StreamTokenizer treats a ' as the start of a String, ending when another quote character is read or the end of the line is scanned. A StreamTokenizer is a very old class; as the API documentation says, don't use it.

[Norm]

If you add
st.wordChars('\'', '\'');

my version of the program prints out: Found "Java" 10 times.


See post #13