Quick Optimizing question

[sgthale]

Im fairly new to java and im an optimize freak. Say i have objects that each have its x,y, speed x, speed y, color, etc. Would it be faster to access those variables by setting them as public or making functions to return each specific variables? Or if you have a better suggestion to how to store lots of variables, tell me!

[sunde887]

If you have a class with these variables you want to encapsulate them by making them private. You can directly access them inside the class, and use setters and getters to handle them from outside of the class.

[Fubarable]

Im fairly new to java and im an optimize freak. Say i have objects that each have its x,y, speed x, speed y, color, etc. Would it be faster to access those variables by setting them as public or making functions to return each specific variables? Or if you have a better suggestion to how to store lots of variables, tell me!

Please read the section titled "Write Dumb Code":
Writing Better Code: A Conversation With Sun Microsystems Technology Evangelist Brian Goetz

[sgthale]

If you have a class with these variables you want to encapsulate them by making them private. You can directly access them inside the class, and use setters and getters to handle them from outside of the class.

thanks for the response but my question is if thats faster or slower than just setting them as public :confused:

[sunde887]

I believe it should be roughly the same speed, it may be a tiny bit faster to access them directly because it doesn't have to call the method, the difference in speed won't be noticeable. You probably don't want to be optimizing something like this unless you absolutely need to increase performance. Also check out fubars link.

[Junky]

I once read someone say micro-optimisations make puppies cry.

By making your instance variables public the gain is only miniscule. On the other hand you break the concept of encapsulation. Another thing to consider is if you make the variable only acessible via a setter is that you can control what values can be assigned to the variable.

[Maximus-EVG]

Heh I thought about that question myself when I was starting out Java and writing getters and setters for private instance variables. Of course its faster to have them as public, as then the JVM will avoid putting that method and its local variables on the stack, which would take about 3 operations per access (push method to stack and local vars to stack, get var, pop the method off the stack...something along those lines).

Faster yes, but by a minuscule amount. + Your variables are exposed for all the other classes to see, and any other programmer using your class can do
sgthale.money = -1000000;
With a setter of course, you wouldn't allow that :D.