Printing keyboard input to screen.

[adwodon]

Ok so I have the following class:

package module8;

import java.io.*;

public class KeyBoardThread implements Runnable {
	
	private Thread t;
	
	public KeyBoardThread(){}
	
	@Override
	public void run() {
		String s = null;
		while(t!=null){
			BufferedReader br = new BufferedReader(new InputStreamReader(System.in));
			try {
				s = br.readLine();
			} catch (IOException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}
			
			if(s.contains("EXIT")){
				stop();
			}
			System.out.println(s);
			
		}
	}
	
	public void stop(){ //nullify the thread to cause any running method to stop
		t=null;
	}
	
	public void start(){ // starts new thread
		if(t==null){
			t = new Thread(this,"KeyBoardThread");
			t.start();
		}
	}

}

I run it with this:

KeyBoardThread testKeyBoardThread = new KeyBoardThread();
		testKeyBoardThread.start();
		testKeyBoardThread.run();

Its supposed to take one line of input and print it screen and the thread stops when the string "EXIT" is detected, however when I tested, it only prints to screen or acknowledges the EXIT after return has been pressed twice.

Anyone offer any reason why its doing this?

[Fubarable]

I have a question for you: why are you explicitly calling run() on this object?

[adwodon]

The final module of my java course is on Threads / Graphics & Applets.

This is the first part of the exercises we were given. We have four threads running, one taking keyboard input, one reading a URL and printing the contents, one telling the time, one telling how much memory is being used.

[Fubarable]

You still need to evaluate why you are specifically calling run() on your KeyBoardThread Runnable object. Your code is effectively calling this method twice, once invoked by the Thread object when its start() method is called, and once directly called by you. Please Google and check out the Oracle tutorial on Threads for more on this, but I can't help but wonder if your directly calling this method is not messing you up.

[adwodon]

Yep I see what you mean now, just read the API, didnt realise the start() method would call the objects run() method.

Thanks!
Problem solved :)