Matrix class

[maz22]

Hi!
I have a program that should read in two matrix from console and add them together then write out the new matrix in matrix form. But that doesn't work. Please help.

Main.java

package javaapplication8;

import java.util.*;
import java.io.*;

public class Main {

    public static void main(String[] args) {
        try{
            new InputMenu();
        } catch (FileNotFoundException e){
                    System.err.println("Hibás paraméter");
                    return;
                }
    }
}

InputMenu.java

package javaapplication8;

import java.util.*;
import java.io.*;

    public class InputMenu
    {

        int [][] s;
        int [][] m1;
        int [][] m2;
        int row;

	    Scanner e = new Scanner(System.in);
            MatrixOperations f = new MatrixOperations();

            System.out.println("Give the number of the rows:\n");
            row=e.nextInt();
            f.getROW(row);
            int [][] m1 = new int[row][row];
            for(int i = 0; i < row; i++){
            for(int j = 0; j < row; j++){
                m1[i][j] = e.nextInt();
                //System.out.print(" "+ t1[i][j]);
                }
            }
            
            System.out.print("Second matrix:\n");
            int [][] m2 = new int[row][row];
            for(int i = 0; i < row; i++){
            for(int j = 0; j < row; j++){
                m2[i][j] = e.nextInt();
               // System.out.print(" "+ t2[i][j]);
                }
            }
            f.MatrixAddition(m1, m2);
            f.MatrixOut();
}

MatrixOperations.java

package javaapplication8;

import java.util.*;

public class MatrixOperations {
	public int row;
	public int[][] m1;
        public int[][] m2;
        public int[][] s;

    public int [][] MatrixAddition(int [][] m1, int [][] m2){
        for (int i=0; i<row; i++)
        {
            for(int j=0; j<row; j++)
            {
                s = new int [i][j];
                s[i][j]=(m1[i][j] + m2[i][j]);
            }
        }
        return s;
    }

    public void MatrixOut(){
        for (int i=0; i<row; i++)
        {
            for(int j=0; j<row; j++){
            
                System.out.println(s[i][j]);
            }
        }
    }

    public int getROW(int row){
        return row;
    }
  }

[pbrockway2]

Perhaps you could say what this code *does* do - does it compile? If so, what happens when you run it?

A couple of things look a bit weird though:

} catch (FileNotFoundException e){

FileNotFoundException? Why?

f.getROW(row);

This line of code does absolutely nothing - which is not going to be good for the program. So what was it intended to do? And do you see why it does nothing?

[maz22]

Actually the filenotfoundexception part is from a different code and I didn't post out the whole code, because I have problem with the matrix read in and addition. When I compile the code it gives me null.

[argus]

hi,

i'm definitely not sure, and never tried matrixes so far.But "row=e.nextInt()" seems to be initialized always to the same value.
Maybe put in this in a loop:

while((row=e.hasNext())!=null){...}

But i really don't know.

[Ronin]

maz22,

Firstly, welcome to the forums.

There are two problems I can spot with your code.

Firstly, the value of row is not set so defaults to zero. Instead, assuming m1 and m2 have been checked to ensure they are the same size, you can call m1.length() and m1[].length().

Secondly, 's' is redeclared within the for loop of the MatrixAddition method. This should be declared outside of the loop using the sizes determined in the first point.

Regards.

[maz22]

Thanks everybody, now it actually works.