Superclass question

**keo** · 10-11-2010, 10:27 AM

I am refactoring a few classes to form a superclass.

If I have a method header that appears in all my sub classes, but contain different bodys and parameters in it, how do i check which class requested it? Or would I just leave the method in its own class?
Thanks

**masijade** · 10-11-2010, 11:06 AM

Why would you need to "check which class requested it"?

In any case, if the signatures are not the same (and they are not when there are different arguments) then it does not belong in some abstract "super" class.

**keo** · 10-11-2010, 11:16 AM

The method signatures are the same, but the bodys are different, and will cause action to variables belonging uniquely to each class.

**Ronin** · 10-11-2010, 11:29 AM

Keo,

You could just leave them as is, but I would place an abstract method in the super class to ensure consistancy. This does mean that ALL sub-classes must override the method, but it does make calling the method from an array of different sub-classes easier.

Regards.

**masijade** · 10-11-2010, 11:43 AM

Originally Posted by Ronin

but I would place an abstract method in the super class to ensure consistancy

Which you can't do if they have different parameters, as stated in the OP. Unless of course you want to do an Object varargs which completely defeats the purpose and would no longer ensure "consistency" in any way, shape, or form.

**keo** · 10-11-2010, 11:45 AM

Okay, Thank you everyone!

**Ronin** · 10-11-2010, 11:48 AM

Originally Posted by masijade

Which you can't do if they have different parameters, as stated in the OP.

You are quite right, but given the OP's second post which stated that the signatures where the same, I assumed they confused the term parameters with variables.

Regards.