Rename files in a directory

[rgeurts]

Hello,

I am trying to create a java app that scans through a specfic folder and renames all the files in it.

My code seems to be working but it refuses to rename any files.
I have spent hours looking at it and i don't know what's wrong.
Can anyone please have a quick look at it and let me know if you can spot any errors.

import java.io.*;

public class Reader {

public static void main(String[] args){

File myDir = new File("c:/temp");

String[] myFiles = myDir.list();

for (int i = 0; i < myFiles.length; i++){

System.out.println("processing file: " + myDir.getAbsolutePath() + "/" + myFiles[i]);


File oldFile = new File(myFiles[i]);

File newFile = new File("c:/temp/test"+i);

System.out.println("......The file will be renamed to " + newFile);

boolean isFileRenamed = oldFile.renameTo(newFile);

if(isFileRenamed) System.out.println("......File has been renamed");

else System.out.println("......Error renaming the file");

			}

		}

}

[JosAH]

What are the names of your old files?

kind regards,

Jos

[rgeurts]

Thanks for taking the time to help Jos.
The names of my old files are:
-blabal.txt
-pleaseworkpieceofshit.txt

I tried renaming the files numerous times. Also I changed the file types.

Can you try to run the code on your computer and see what happens?

Thanks

[gcalvin]

1. C:\TEMP is probably safe enough, but there are some versions of Windows and other software that put things there, so be careful.

2. Take another good long look at the Jave File API document. Particularly look at the renameTo() method.

-Gary-

[rgeurts]

Hi Gary,

Thanks for the response.
i spent hours looking for an anser on this one but I am not smart enough to find anything wrong with my code

[JosAH]

Hi Gary,

Thanks for the response.
i spent hours looking for an anser on this one but I am not smart enough to find anything wrong with my code

Suppose you have a file c:/usr/foo/data.txt. It'll show up in your array as a string "data.txt", i.e. no path information is passed. When you reconstruct a new File object for the file you're reconstructing it relative to where your java program runs (the file doesn't exist there). Do this instead:

File myDir = new File("c:/tmp/");

File[] myFiles = myDir.listFiles();

for (int i = 0; i < myFiles.length; i++) {

	System.out.println("processing file: " + myDir.getAbsolutePath()
					+ "\\" + myFiles[i]);

	File oldFile = myFiles[i];

	File newFile = new File("c:/tmp/test" + i);

	System.out.println("......The file will be renamed to " + newFile);

	boolean isFileRenamed = oldFile.renameTo(newFile);

	if (isFileRenamed)
		System.out.println("......File has been renamed");
	else
		System.out.println("......Error renaming the file");
}

kind regards,

Jos

[rgeurts]

Hi Jos,

Thanks very much for the code.
I will give it a shot tonight and will let you know if it solved my issue.

Thanks again!

[rgeurts]

Hello Jos,

Thanks for helping out.
I have got my first java app working now.