Array length and printing out uninitialized array.

**nicolek808** · 09-07-2009, 11:33 AM

I am having trouble setting array length. My program reads in a file and reads integers only. However, I can print out all the integers, but once the last integer is read, it prints out 'null' until the declared array length ends.
below is my code:

Java Code:

  import java.util.Scanner;
   import java.io.File;
   import java.util.StringTokenizer;
   import java.util.InputMismatchException;
   import java.io.FileNotFoundException;
   import java.util.NoSuchElementException;

	

    public class KashiwabaraNicole3
   {
     /*******************************************************************************
     *  Outputs integers from user input external files.
     ********************************************************************************/
    
       public static void main(String[] commandlineArguments)throws InputMismatchException 
      {
         if(commandlineArguments.length == 0)
         {
            System.out.println("Please enter the file name " +
               "as the 1st commandline argument.");
         }
         else
         {
            Integer[] array = KashiwabaraNicole3.readFileReturnIntegers(commandlineArguments[0]);
            KashiwabaraNicole3.printArrayAndIntegerCount(array, commandlineArguments[0]);
         }
      }	
       public static Integer []readFileReturnIntegers(String inputFile)
      {
        
         Integer [] array = new Integer [8000];
        
         Integer size = new Integer(0);
         File file = new File(inputFile);
            
         Scanner scanFile = null;
            
         try {
            scanFile = new Scanner(file);
         } 
             catch (FileNotFoundException exception) {
                  
               System.out.print("ERROR: File not found for \"");
               System.out.println(inputFile +"\"");
            }  
                   
         if(scanFile != null)
         {
           
            while (scanFile.hasNextLine()) 
            {   
               try
               {                       
                  int element = scanFile.nextInt();
                  array[size] = element;
                  ++size;								  
               }
                   catch (InputMismatchException exception)
                  {
                     scanFile.next();
                  } 
                  catch (NoSuchElementException exception)
            		{
            		  scanFile.next();
            		}        
            }
         }
      
         return array;          
      }
      
       public static void printArrayAndIntegerCount(Integer [] array, String inputFile)
      {
         int num = 0;     
         System.out.println("number of integers in file " + inputFile + " = " + array.length);
      
         for (int i = 0; i < 10; i++)
         {
            System.out.println("index = " + i + ", element = "+ array[i]);
            
         }
      
      
      }
      	
      																																																																								
      	     
   }

The file name is inputted into the args.
Ive attached the files.
My output for electricity:
number of integers in file electricity.txt = 8000
index = 0, element = 1877
index = 1, element = 1923
index = 2, element = 1879
index = 3, element = 2000
index = 4, element = null
index = 5, element = null
index = 6, element = null
index = 7, element = null
index = 8, element = null
index = 9, element = null.....(until index = 8000, element = null)

Thank you so much in advance for your help!!! :)

**mtyoung** · 09-07-2009, 11:58 AM

as length of array is 8000

Java Code:

Integer [] array = new Integer [8000];

if you loop though the array, 8000 output print
i suggest you LinkedHashMap, Vector etc to store the integer
or you can try to return value of "size", so that you can loop for 0 to < size only

**nicolek808** · 09-07-2009, 12:09 PM

Thank you for your suggestion. :)

I tried using size as the array length, however, I cannot pass it into the method.

I believe it has something to do with passing 'element' into the array.
I have re-written as:

Java Code:

array[size] = scanFile.nextInt();
                  ++size;

and now I get a NoSuchElementException.

Any Suggestions for this?

**Fubarable** · 09-07-2009, 02:24 PM

1) As noted above, why not use a varaible sized collection instead of a fixed-sized array?
2) If you must use a large fix sized array, (sorry if I'm oversimplifying), why not check if the element is null before printing it? If not null, print it, if null, break out of the for loop.