Help with this stack application

[le_albina@hotmail.com]

Hi!

I have to modify the following code that constructs a stack so it can duplicate its length once it is full. I have also to modify the pop method so it can reduce the stack length by half if the quantity of elements is less than half of the length. The 'new' code has to keep the old elements. So far I changed the push method and it works (duplicates the stack length when is full) but I have problems with the pop. I would appreciate any help.
Thanks in advance


//Original code with the new push




public class SimpleStack{

private Object[] stack;
private int top;

public SimpleStack(int capacity){//método constructor
stack=new Object[capacity];
top=0;
}//end SimpleStack

public boolean isEmpty(){
return top==0;
}//end isEmpty

public boolean isFull(){
return top==stack.length;
}//end isFull

public void push(Object item){
if (isFull()){
System.out.println ("Stack overflow");
stack= new Object [2*stack.length];
}else{
stack[top++]=item;
}
}//termina método push

public Object pop(){
if(isEmpty()){
System.out.println("Stack underflow");
} else{
return stack[--top];

}//end pop
}//end class SimpleStack




// This is my pop method modification

public Object pop(){
if(isEmpty()){
System.out.println("Stack underflow");
}else{
if(top<(stack.length)/2){
stack=new Object[stack.length/2];
} else{
return stack[--top];
}}//end both else
}//end pop
}//end class SimpleStack

[mtyoung]

your push method seems remove all data stored before

your pop method also remove all data stored if top<(stack.length)/2

for "changing" length of array, you need to copy the data from the "old" array to "new" array

[le_albina@hotmail.com]

How can I store the data?

[Mr.Beans]

Check out the arrayCopy method. It will allow you to easily copy the contents of your old array to a new array.

Also you do realize that when you do

stack= new Object [2*stack.length];

You are making stack reference to a new array of Objects (which is empty).
This is one case you may want to copy the array.
The other case would be when you want to decrease the size of the array by half in the pop method.

Mr.Beans

[le_albina@hotmail.com]

I don't know if I can use the arrayCopy method. Is there another option to create the new array and put the data in the same order that was in the old one? Or, can be possible to double the length of the old array so it keeps the data?
Thanks

[CJSLMAN]

there another option to create the new array and put the data in the same order that was in the old one?

Yeap... use a "for" loop... along with: newArray[i] = oldArray[i]

can be possible to double the length of the old array so it keeps the data?

If it's the Array class, no. If you use ArrayList class, then you shouldn't have any problems

Luck,
CJSL