[SOLVED] Search problem - array out of bounds

[viper110110]

Hey guys, I am trying to make a search for a 2D array. I am using a program called "Ready To Program Java" (school assignment). My 1D searches using my logic work exactly as planned, however my 2D does not.

public static String[] [] search (String searchFor, String word[] [], int length, int width)
    {
        boolean[] valid;
        valid = new boolean [length];
        int found = 0, j = 0;

        for (int i = 0 ; i < length ; i++)
        {
            valid [i] = false;
        }
        for (int i = 0 ; i < length ; i++)
        {
            //for (int k = 0 ; k < width ; k++)
            //{
            if (word [i] [0].compareTo (searchFor) == 0)
            {
                valid [i] = true;
                found++;
                //k = width;
            }
            //}
        }
        
        String results[] [] = new String [found] [width];
        

        for (int i = 0 ; i < length - 1; i++)
        {
            //for (int k = 0 ; k < width ; k++)
            //{
            if (valid [i] = true)
            {
                results [j] = word [i];
                j++;
            }
            //}
        }
        return results;
    }

it is returning the error

java.lang.ArrayIndexOutOfBoundsException: 1
at Search.search(Search.java:142)

thanks in advance

[Fubarable]

Use the array's own lengths to help you avoid going out of bounds:

public class Fubar
{

  public static void main(String[] args)
  {
    int[][] my2dArray = 
    {
      {1, 2, 3},
      {5, 7, 2}, 
      {0, -20, 10},
      {1, 1, 1}
    };
    
    for (int i = 0; i < my2dArray.length; i++)
    {
      for (int j = 0; j < my2dArray[i].length; j++)
      {
        System.out.print(my2dArray[i][j] + ", ");
      }
      System.out.println();
    }
  }
}

[CJSLMAN]

Why is there a "length-1" in your for cycle if your looping through the valid array?

for (int i = 0 ; i < length - 1; i++)

... besides, I agree with Fubarable's suggestion

Luck,
CJSL

[viper110110]

solv'd

but it wasn't any of the solutions above

I had

if (valid [i] = true)

which made valid true no matter what

I now have

if (valid [i] == true)

and now it works

[Fubarable]

It's far better and cleaner just to write:

if (valid[i])

[viper110110]

It's far better and cleaner just to write:

if (valid[i])

thanks, I'll remember that one