Client Server Communication

[MichaelH]

Hello,

I have a Server and a Client. The Client tries to receive a file from the Server. The Server sends the content of the File and a header. My Client works fine but I have a problem with my Server.

I start the Server with

> java Server <port>

.
And the Client with

> java Client <name of Server> <port> <file>

Every time I send a request with my Client to the Server I get always 200 ok as response, it doesn't matter if the file exists or not. The file is always in the same folder as the Server. So I don't know whats wrong with my Server-Code. If the file doesn't exists the response should be 404 Bad Request but it is always 200 ok, but why?

That's my Server:

import java.io.*;
import java.net.*;

public class Server {
	
	private int port;
	private String type = "txt";
	
	public Server(int port) {
	this.port = port;
	}
	
	public void startServer() {
		try {
			ServerSocket server = new ServerSocket(port);
			
			InetAddress addr = InetAddress.getLocalHost();
			System.out.println("HTTPServer " + addr.getHostName() + "/" + addr.getHostAddress() +
					":" + port + " started ...");
		
		while (true) {
			Socket client = server.accept();
			File file = new File("data.txt");
			byte[] bytearray = new byte [(int)file.length()];
			BufferedOutputStream out = new BufferedOutputStream(client.getOutputStream());
			FileInputStream inputStream = new FileInputStream(file);
			BufferedInputStream bis = new BufferedInputStream(inputStream);
			bis.read(bytearray,0, bytearray.length);
            OutputStream outputStream = client.getOutputStream();
			
			try  {
				
				if(file.exists()) {
				
				
				String header = "HTTP/1.1 200 OK\r\n" + "Content-Type: " + type + "\r\n" + 
				"Content-Length: " + file.length() + "\r\n\r\n";
				
				outputStream.write(header.getBytes());
				 
				outputStream.write(bytearray,0,bytearray.length);
				 
				 } else (!file.exists()) {
					String header = "HTTP/1.1 404 Bad Request\r\n" + "Content-Type: " + type + "\r\n" + 
							"Content-Length: " + file.length() + "\r\n\r\n";
					outputStream.write(header.getBytes());
				
			}	
		
				out.flush();
				out.close();
			
			}
			catch(IOException e) {
				System.err.println(e);
			} 
			finally {
				try {
					if(client != null)
						client.close();
					if(inputStream != null)
						inputStream.close();
				}
				catch(IOException e) {}
				
			}
			}
		
		}
		catch(IOException e) {
			System.err.println(e);
		}			
		
		
		}
		public static void main(String[] args) {
			if(args.length != 1) {
				System.err.println("HTTPServer <port>");
				System.exit(1);
		}
			int port = Integer.parseInt(args[0]);		
			
			new Server(port).startServer();
			}
			}

And this is my Client:

import java.io.*;
import java.net.*;

public class Client {
	public static void main(String[] args) throws UnknownHostException, IOException {
		
		String serverName = new String(args[0]);
		int port = Integer.parseInt(args[1]);
		String file = args[2];

	        Socket s = new Socket(serverName, port);
	        OutputStream os = s.getOutputStream();
	        PrintWriter pw = new PrintWriter(os, false);
	        pw.println("GET " + "http://" + s.getInetAddress() + file + " HTTP/1.1" + "\n");
	        pw.println();
	        pw.flush();
	        
	        InputStream in = s.getInputStream();
	        InputStreamReader isr = new InputStreamReader(in);
	        BufferedReader br = new BufferedReader(isr);
	        String line;
	        while ((line = br.readLine()) != null) {
	          System.out.println(line);
	        }
	}
	  
	  }

Thank you for your help!

[bakstar]

Perhaps it is because this doesn't output a boolean.

!file.exists()

Try it with

if(file.exists()) {

//Enter stuff if there is a file

} else {

//Enter stuff if there isn't a file

}