Collision in j2me

[Ashish_jain]

why collision not happen in this code-

if (((AppleX >= OctoXpos) && (AppleX <= OctoXpos + imgBell.getWidth()))
|| ((AppleX + imgApple.getWidth() <= OctoXpos) && (AppleX + imgApple.getWidth() >= OctoXpos + imgBell.getWidth()))
&& ((AppleY >= OctoYpos) && (AppleY <= OctoYpos + imgBell.getHeight()))
|| ((OctoYpos + imgBell.getHeight() <= AppleY) && (OctoYpos + imgBell.getHeight() >= AppleY + imgApple.getHeight()))) {



}

[Norm]

Try debugging the code by printing out the values of the variables and the results of the all the sub conditions.
Give the code values that are collusions and values that are not and compare the results to see why the code does not work when there is a collusion.

[Ashish_jain]

I have done this but no result found.condition is correct or not?

[Norm]

Then you must have missed some of the combinations of conditions.
Make a table of all the conditions with all their values and make sure you send all the values to your code.
Run all the values thru your conditions and record the results.
When the results are wrong, look at the logic and see which tests are wrong.

If you are having problems, write a program that executes the code and passes it various combinations of values and post it with a driver that sends the code values that should be a collusion and values the are not a condition.

[JosAH]

why collision not happen in this code-

if (((AppleX >= OctoXpos) && (AppleX <= OctoXpos + imgBell.getWidth()))
|| ((AppleX + imgApple.getWidth() <= OctoXpos) && (AppleX + imgApple.getWidth() >= OctoXpos + imgBell.getWidth()))
&& ((AppleY >= OctoYpos) && (AppleY <= OctoYpos + imgBell.getHeight()))
|| ((OctoYpos + imgBell.getHeight() <= AppleY) && (OctoYpos + imgBell.getHeight() >= AppleY + imgApple.getHeight()))) {
}

When I look at the expressions from a birdeye view, I want to see something like this:

if ((Ax || Bx) && (Ay || By)) ...

The 'A' expressions seem ok, but those 'B' expressions are a bit mixed up.

kind regards,

Jos

[Ashish_jain]

imgbell.getWidth() point to -> OctoWidth.
And imgApple.getWidth() point to -> AppleWidth. and i m trying to collision b/w Apple and Octopus.

[Norm]

Here is how I suggest you find the problem with your code:
Make a simple method that executes your if test and returns true or false.
Then pass that method values that are not collisions and values that are collisions.

Then break the if with all its conditions up into separate sub conditions and print out the results of each sub condition.
Then look at the output to see which sub test is wrong.

[Ashish_jain]

i also do this with boolean but no result.but thanks for support.i will check again. :)

[Norm]

Another suggestion, reformat the conditions so that their nesting level is visually shown.
Your code is too compact and very poorly aligned and does not show the nesting level.