Get selected Node Value of a child element

[Ms.Ranjan]

Hi

I am using DOM to parse an xml file.Below is my xml file

<?xml version="1.0"?>
<root>
<parent att1="val1">
<child1>childvalue</child1>
<child2 att2="val2">
<child3>10093</child3>
<sibling att3="val3"/>
</child2>
</parent>
</root>

The code to extract text node value

import java.util.ArrayList;
import java.util.List;
import javax.xml.parsers.*;
import org.omg.CORBA.Any;
import org.w3c.dom.*;
public class Parsing {
private static final String FILE_NAME_STRING = "test.xml";

public static void main(String args[]) {
  List childlist = new ArrayList();
  try {
    
    DocumentBuilder builder;  
    DocumentBuilderFactory factory = DocumentBuilderFactory
        .newInstance();  
    builder = factory.newDocumentBuilder();
    Document document = builder.parse(FILE_NAME_STRING);    
    Element node = document.getDocumentElement();
    recurseThroughDoc(node);

  } catch (Exception e) {
    e.printStackTrace();
  }
}

private static void recurseThroughDoc(Node node) {
		
  int type = node.getNodeType();
   if (type == Node.TEXT_NODE && !(node.getNodeValue()==null)&& !(node.getNodeValue()=="")) {
    //System.out.println("Type: Text Node");
    System.out.println("Value: " + node.getNodeValue() + "");
  } 
  NodeList nodeList = node.getChildNodes();  
  if (nodeList.getLength() > 0) {
    for (int i = 0; i < nodeList.getLength(); i++) {
      recurseThroughDoc(nodeList.item(i));
    }
  }}
}

The output which i get is

Value: 

Value: 

Value: childvalue
Value: 

Value: 

Value: 10093
Value: 

Value: 

Value: 

Value:

But what i actually want is only the value:10093,the child3 element's node value.Since its of type text node,when i try to get the nodename i get #text
So how do i get only the nodevalue of child3 alone??

Any suggesstion please...
Thanks

[Fubarable]

Perhaps XPath would work well for you.

[Fubarable]

Also, this is a no-no:

if (type == Node.TEXT_NODE && !(node.getNodeValue()==null)&& !(node.getNodeValue()=="")) {

as you should almost never compare Strings with ==.

This may work better:

if (type == Node.TEXT_NODE && !(node.getNodeValue()==null)&& !(node.getNodeValue().trim().isEmpty())) {

[Fubarable]

Here's an example using XPath, but I warn you that I'm still a neophyte with this and there may be errors. If anyone sees any, please correct:

import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;

import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpression;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;

import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
import org.xml.sax.SAXException;

public class XPathReader1 {

   //  **** you'll have to change the path string to match your needs
   private static final String XML_PATH_STRING = "src/yr2009/m09/b/test.xml";
   private static final String XPATH_EXPRESSION = "//child3/text()";

   public static List<String> getTraceNumbers(String path, String expression)
            throws ParserConfigurationException, SAXException, IOException,
            XPathExpressionException {
      DocumentBuilderFactory domFactory = DocumentBuilderFactory.newInstance();
      domFactory.setNamespaceAware(true);
      DocumentBuilder builder = domFactory.newDocumentBuilder();
      Document doc = builder.parse(new File(path));

      XPathFactory xFactory = XPathFactory.newInstance();
      XPath xpath = xFactory.newXPath();
      XPathExpression expr = xpath.compile(expression);

      Object result = expr.evaluate(doc, XPathConstants.NODESET);
      NodeList nodes = (NodeList) result;
      List<String> vOne = new ArrayList<String>();
      for (int i = 0; i < nodes.getLength(); i++) {
         String nodeText = nodes.item(i).getNodeValue().trim();
         vOne.add(nodeText);
      }

      return vOne;
   }

   public static void main(String[] args) throws XPathExpressionException,
            ParserConfigurationException, SAXException, IOException {
      System.out.println(getTraceNumbers(XML_PATH_STRING, XPATH_EXPRESSION));
   }

}

[Ms.Ranjan]

Thanks,I will go through the code and learn about XPath,its sad that i could not do with dom,anyway thanks....

[Fubarable]

Thanks,I will go through the code and learn about XPath,its sad that i could not do with dom,anyway thanks....

It can be done with DOM, never said it couldn't. Did you read my comment about your using == to compare Strings?

[Ms.Ranjan]

yes,its the sample code that i use for testing purpose and clarifying issues,my original one does have the change,i will the change in this also..

Thanks.
PS: I'd appreciate if you could suggest me on how to deal the issue with dom too..