Shared array between Threads?

[driiper]

Hello, and hi Java-forums.org!

I just started up learning java and im currently creating a Multithreaded server.
So each client connecting to the server is put into a Thread and then it does it magic. Everything is working fine except the part where the server needs to echo back client message to ALL clients. currently its only working 1 on 1
(Server <--> Client).

So, my plan is to create a shared array that which stores all the client objects, and then it would loop through the array sending to every client.
I have no idea if that even works or if there is any better way of doing it (have been googling for the last two hours).

So here is my client_thread code

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.PrintWriter;
import java.net.Socket;


public class client_threads extends Thread {

	Socket clientSocket;
	int clientID = -1;
	boolean bRunThread = true;
	public Object[] clients = new Object[10];
	
	
	client_threads(Socket socket, int id)
	{
		clientSocket = socket;
		clientID = id;
		clients[id] = clientSocket;
	}
	
	public void run()
	{
		BufferedReader in = null;
		PrintWriter out = null;
		
		//Print ut detaljene av den aksepterte klienten.
		System.out.println("Accepted client : ID - " + clientID + " : Address - " + clientSocket.getInetAddress().getHostName());
		
		try{
		  in = new BufferedReader(new InputStreamReader(clientSocket.getInputStream())); 
          out = new PrintWriter(new OutputStreamWriter(clientSocket.getOutputStream())); 
		
          	while(bRunThread)
          	{
          		//Read incoming stream
          		String clientRead = in.readLine();
          		System.out.println("Client" + clientID +  " says: " + clientRead);
        	  
          		if(clientRead.equalsIgnoreCase("quit"))
          		{
          			bRunThread = false;
          			System.out.println("Stopping the thread for "+ clientID);
          		}
          		else
          		{
          			//Echo back to client
          			out.println(clientRead);
          			out.flush();
          		}
          	}
		}catch(Exception e){e.printStackTrace();}
		finally
		{
			try{
			//Cleaningoutthecloset
			in.close();
			out.close();
			clientSocket.close();
			}catch(IOException e){e.printStackTrace();}
		}
	}
}

Yeh thats pretty much it. ive been trying to use this the array called

Object[] clients = new Object[10];

but didnt have any luck in sharing it.


All help is appreciated!

Thank
Driiper

[Norm]

Using an array of Object is not the way to do it. Use an ArrayList that is defined to hold client class objects.

[driiper]

Using an array of Object is not the way to do it. Use an ArrayList that is defined to hold client class objects.

sweeeet. it works!

Thank you :)

driiper