Are static methods thread safe?

[sinisa.medic]

Hello,

I have created a utility class that has one static method. This method will be used by multiple threads. My static method has accepts two arguments and based on them it returns some value. The method is never dependent upon any member variables in FormUtils class. I am wondering is it thread safe?

public class FormUtils {

    public static int compareLength(String strValue, String strLength) {
        
        // Set the initial length value
        int length = 0;
        
        try {
            length = Integer.parseInt(strLength);
        }
        catch (NumberFormatException e) {
            // Ignore - this will happen if the passed in value is null or empty
        }
        
        if (strValue == null) {
            if (length < 0) {
                return 1;
            }
            else if (length == 0) {
                return 0;
            }
            else {
                return -1;
            }
        }
        else {
            if (length < strValue.length()) {
                return 1;
            }
            else if (length == strValue.length()) {
                return 0;
            }
            else {
                return -1;
            }   
        }
    }

}

Moderator Edit: Code tags added

[iluxa]

yeah, it is, you're good.

[sinisa.medic]

Even though I am passing two string arguments, which are not Java primitive types? If I had multiple threads going through that method concurrently? Would I achieve the result that I expected?

[Fubarable]

Hello, and welcome to the forum. I hope you don't mind that I edited your code and added code tags which should help make your posted code retain its formatting and be more readable.

To do this yourself, highlight your pasted code (please be sure that it is already formatted when you paste it into the forum; the code tags don't magically format unformatted code) and then press the code button, and your code will have tags.

Another way to do this is to manually place the tags into your code by placing the tag [code] above your pasted code and the tag [/code] below your pasted code like so:

[code]
  // your code goes here
  // notice how the top and bottom tags are different
[/code]

Best of luck, and again, welcome!

[iluxa]

when different threads will be calling your method, they will all pass their own version of the arguments. Think of it this way: each thread creates its own version of your method and runs that. No conflicts. The arguments are owned by the thread.

Now, if your method accessed some class variables, then all the "versions" of your method would be talking to the same objects - problem.

[Fubarable]

Cross-post: Java Programming - Is my static method thread safe?

Please read what JavaRanch says about cross-posting without being forthright about it: JavaRanch - Be Forthright When Cross Posting To Other Sites]

The same etiquette applies here and in the other programming fora.

[JosAH]

The spammer is gone so my reply is out of context now (edited)

kind regards,

Jos