Thread won't stop

Hi all.

I'm trying to do a long intensive task while updating a JLabel in the GUI.
On a certain point, the Thread needs to stop.
The problem is that it doesn't stop, it keeps updating the JLabel.

Code:

---

public void run() {
  while(!threadDone) {
    for(int i = 0; i < 100000; i++) {
      model.getLabel().setText(Integer.toString(i));
      if(i == 50000) {
        threadDone = true;
      }
    }
  }
}

---

After 50000 is passed, it keeps updating.
Any help is appreciated.

You might have to post more code. A SSCE.

This is my program but simplified.

Pseudo code:

Code:

---

For-loop (1 to 5)
  For-loop (array of 62)
    For-loop (array of 62)
      For-loop (array of 62)
        For-loop (array of 62)
          For-loop (array of 62)

---

The main problem is that, the code around it works just fine, only the while loop isn't stopped when setting threadDone to true.

Is it stopping when i is 100000?

No, it just keeps repeating the whole process because of the while loop.

Like I said, post a self compiling runnable example that demonstrates this problem.
Also does the update go on until 100000?

Don't bother. You set the flag but you don't break the for loop.

It's quite a big example if i need to to post everything here.
I got the run() method, and 6 loops in eachother.

Code:

---

run(while(loop(loop(loop(loop(loop(loop)))))));

---

All the loops execute fine, only the while always stays true so eveything repeats over and over again.

Read my latest response. You set the flag but the loops still run to completion. Better break them to force execution out of the while loop.
Loop basics actually.

The loop is inside the thread so if the thread stop, the loop should stop, right?

Are you reading what r035198 is writing? You may wish to acknowledge his statements and why you choose to accept them or reject them.

I did read it and understand it.
I will have to break the loop and then check if the thread needs to stop and if so, I need to stop the thread.

Code:

---

for() {
  for() {
    for() {
      if() {
        break;
      }
    }
    if(isBroken) {
      threadDone = true;
    }
  }
}

---

Since I have 6 loops, I will have to do this 6 times.

I used a branching statement for the while loop, now it works.

Thanks for your help.

You can break out the entire loop via a break to a label:

Code:

---

  public static void main(String[] args) {
    int i = 0;
    int j = 0;
    int k = 0;

    done:
    while (true) {
      for (i = 0; i < 10; i++) {
        for (j = 0; j < 10; j++) {
          for (k = 0; k < 10; k++) {
            if (i == 2 && j == 3 && k == 4) {
              break done;
            }
          }
        }
      }
    }

    System.out.println(i + ", " + j + ", " + k);
  }

---

Or even simpler, put the loops in a method and just call return.

Quote:

---

Originally Posted by Fubarable

Are you reading what r035198 is writing? You may wish to acknowledge his statements and why you choose to accept them or reject them.

---

How dare you call me that?
I'll have to report you to the *SPNEX.





(*)Society for People with Names Ending with X

1000 pardons. It will never happen again this week.

why not just return out of the run method?

Code:

---

if(...)
{
  return;
}

---