custom class doing wierd things

[lenois]

I am testing a custom class, and it seems that no matter what I do, the array only holds the last token in the string. I asked my TA today, and he said that the logic made sense, and that it had to be a compiler error, I just tried it on a different computer and it is still not working. here are the relevant classes, I had an earlier problem with the same thing, but I resolved it.

public class sentenceTest
{
	public static void main(String[]args)
	{
		String test=" banana group g letete dsflajdfio ghithy aklf;asdt akdfjit.";
		Sentence testS= new Sentence(test);
		
		int numWords= testS.countWords();
		
		Word firstWord=testS.nextWord();
		Word secWord=testS.nextWord();
		Word thWord=testS.nextWord();
		Word fourWord=testS.nextWord();
		
		
		System.out.println(numWords+"::::"+firstWord.getWord()+"::::"+secWord.getWord()+"::::"+thWord.getWord()+"::::"+fourWord.getWord());
	}
}

import java.util.StringTokenizer;
public class Sentence
{
	private int numWords=0;
	private int ct=0;
	private Word[] sentence;	
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/ 

	Sentence(String s)
	{
		
		StringTokenizer start=new StringTokenizer(s," ,.");
		numWords=start.countTokens();
		sentence = new Word[numWords];
		
		int i = 0;
		while(start.hasMoreTokens())
		{
			sentence[i]=new Word(start.nextToken());
			System.out.println(sentence[i].getWord());
		

			i++;
		}
		
		for(i = 0; i< numWords; i++)
			System.out.println(sentence[i].getWord());
		
		
	}
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/
	public int countWords()
	{


		return numWords;
	}
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/
	public Word nextWord()
	{
		
	
		Word returnWord=sentence[ct];
		if(ct<numWords){
			ct++;
			}
		System.out.println(ct + " --" + sentence[ct].getWord());

		return returnWord;
	}


}

public class Word
{
	private static final char[]vowels={'a','e','i','o','u','y'};
	private static int numberOfSyllables;
	private static char[]word;
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/	
	Word(String w)
	{
		w=w.toLowerCase();
		word=w.toCharArray();
				
	}
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/	
	public int countSyllables()
	{
		int ct=word.length;
		for(int i=0;i<ct;i++)
		{
			if(isVowel(word[i]))
			{
				if(i==ct-1&&word[i]=='e')
				{
					
				}
				else if(word[i]=='e'&&(word[i+1]=='d'||word[i+1]=='s'))
				{
				}
				else if(i==0)
				{
					numberOfSyllables++;
				}else if(!isVowel(word[i-1]))
				{
					numberOfSyllables++;
				}
			 	
			}
		}
		if(numberOfSyllables>1)
		{
			return numberOfSyllables;
		}else
		{
			return 1;
		}
	}
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/	
	public static boolean isVowel(char ch)
	{
		boolean vowel=false;
		for(int i=0;i<6;i++)
		{
			if(ch==vowels[i])
			{
				vowel=true;
			}
		}
	return vowel;
	}
	/** * Short one line description. (1) * * Longer description. If there were any, it would be [2] 
	* here. * <p> * And even more explanations to follow in consecutive * paragraphs separated by HTML paragraph breaks. 
	* 
	* @param variable Description text text text. (3) 
	* @return Description text text text. 
	*/	
	public String getWord()
	{
		String sWord= new String(word);
		return sWord;
	}
}

here is the output i get


banana
group
g
letete
dsflajdfio
ghithy
aklf;asdt
akdfjit
akdfjit
akdfjit
akdfjit
akdfjit
akdfjit
akdfjit
akdfjit
akdfjit
1 --akdfjit
2 --akdfjit
3 --akdfjit
4 --akdfjit
8::::akdfjit::::akdfjit::::akdfjit::::akdfjit

[jim829]

First, compiler errors are very rare. The problem is that your fields in your Word class are declared static.

  private static final char[]vowels={'a','e','i','o','u','y'}; // static okay here since not part of object state
    private int numberOfSyllables;  // remove static as this should be an instance field
    private char[]word;               // remove static as this should be an instance field

Regards,
Jim

[lenois]

Thank you, I figured it out right when you posted I had stared at the sentence class so long, I didn't even look at the word class.