public int countOccurrences(char c) & public int countOccurrences(String s)

[LetsG0Blue]

Can somebody look at my code in public int countOccurrences(char c) & public int countOccurrences(String s) section and see if they see something wrong? I'm trying to count the number of words in a section with the public int countOccurrences(String s) section and total amount of a single letter in the int countOccurrences(char c) section. Any help would be great!

Thank you.

import java.util.Scanner;


public class Strings {

    private String myStr="";
    
    public void readString()
    {
    	Scanner scan = new Scanner(System.in);
    	System.out.print("Enter a sentence ");
    	myStr = scan.nextLine();
    }
    public void setString(String s)
    {
        myStr =s;
    }
    public int countOccurrences(String s)
    {
    	int count = 0;
    	int index = myStr.indexOf(s);
    	 
    	while ( index >= 0 ) {
    	   index = myStr.indexOf(s, index+1 );
    	   count++;
    	}
		return index;
    	
    }
    public int countOccurrences(char c)
    {
    	for (int i = 0; i < myStr.length(); i++)
    	{
    		char c2 = myStr.charAt(i);
 
            }
		return c;
    	
        }	
    int countUpperCaseLetters()
    {
    	int caps = 0;
		for (int i=0; i< myStr.length(); i++)
		{
			if (Character.isUpperCase(myStr.charAt(i)))
				caps++;
		}
		return caps;
    }

    int countLowerCaseLetters()
    {
		int lowercase = 0;
		for (int i=0; i< myStr.length(); i++)
		{
			if (Character.isLowerCase(myStr.charAt(i)))
				lowercase ++;
		}
		return lowercase;
    }
    public void printCounts(String s, char c)
    {
        System.out.println("***************************************");
        System.out.println("Analyzing: myStr="+myStr);
        System.out.println("Number of "+s + " is "+ countOccurrences(s));
        System.out.println("Number of "+c + " is "+ countOccurrences(c));
        System.out.println("Number of Upper case letters="+ countUpperCaseLetters());
        System.out.println("Number of Lower case letters="+ countLowerCaseLetters());
    }

    public static void main(String[] args) {
    	Strings msm = new Strings();
        msm.readString();
        msm.printCounts("big", 'a');
        
        msm.setString("Parked in a van down by the river bank .... The van had was near a lot of other vans");
        msm.printCounts("van", 'a');
        
        Strings msm2 = new Strings();
        msm2.setString("the elephant in the room wouldn't budge");
        msm2.printCounts("the", 'i');
    }
}

[jim829]

Well, upon first glance it looks like you are returning the wrong value in your counOccurences methods for String and char. More specifically, in counOccurrences(char c) you aren't even counting anything or comparing anything to c.

Regards,
Jim

[LetsG0Blue]

What should I return then? I've been at this for about 10+ hours now and I'm so confused on this matter.

[jim829]

Ok, first, look at the countOccurrences(String s). You are returning index. You should return count.
Second, look at the countOccurrences(char c). You need to do the same thing as for a string. Namely:

• initialize a count variable.
• compare c to c2 and update count variable appropriately
• return count

Jim

[LetsG0Blue]

You are a life saver! ....

Thank you Jim!!