Some truble with simple program

[OPTYMISTA]

I have to write a simple "Black Jack" game with dices. Game can have random number of players.
At the beginning of the game each player roll 3 dices. Program have to add values of the dices and show the result.
Afterwards asks program if you want to continue, also "if you want to roll next dice"...until player answer "no".
Then it should save the value of points this player gained, and go to the next player. When i debugged program it turned out that instead of saving each
"value of points" in arrayPOINTS, it jumpes of whole "for" and value in arrayPOITS is deleted (=0). I don't know how to refer players to an array either.
I'm not so good in "arrays", so I have some though time writin' this program.

Here's my "roll-dice" class:

package practice5;



public class Terning {

	public int dice;

	
	public Terning() {
		roll();
	}

	public int roll() {

			dice = (int)(Math.random()*6) +1;
			return dice;
		}
	
	}

Here's my player class (It should at least save name and value of poits gained) and player method (Ask about name, roll 3 dices and assume values):

package practice5;

import java.util.Scanner;

public class Player {

	static String player;
	static int points;

	public void setPoints(int points) {
		this.points = points;
	}
	public String getPlayer() {
		return player;
	}
	public void setPlayer(String player) {
		this.player = player;
	}
	public int getPoints() {
		return points;
	}


	public void Player() {
		int kast1;
		int kast2;
		int kast3;


		Scanner inn = new Scanner(System.in);
		System.out.print("Name: ");
		player = inn.next();

		Terning terning = new Terning();
		kast1 = terning.roll();
		kast2 = terning.roll();
		kast3 = terning.roll();
		points = kast1 + kast2 + kast3;
		System.out.print(points);
		System.out.println();
		
	}
}

And my main program, with "Turn-method = omGang()":

package practice5;
import java.util.Scanner;

public class MainProgram {


	public static void main(String[] args) {

		int ANTALL_SPILLERE = 2;

		// Hopper ut av while, så blir i=0 igjen.
		for(int j=0;j<ANTALL_SPILLERE;j++) {
			Player spiller = new Player();
			spiller.Player();
			omGang();
		}
	}

	public static void omGang() {
		int ANTALL_SPILLERE = 2;
		boolean choice = true;
		String valg;
		int next_kast;
		int Sum = Player.points;
		//	int ANTALL_SPILLERE = 2;
		String[] Spillere;
		Spillere = new String[ANTALL_SPILLERE];
		int[] Poeng;
		Poeng = new int[ANTALL_SPILLERE];
		Terning terning = new Terning();
		Scanner ny = new Scanner(System.in);

		// hopper ut av løkka etter første omgang, hvorfor lagrer den ikke verdiene?
		for(int i=0;i<ANTALL_SPILLERE+1;i++) {
			while(choice == true) {

				System.out.print("Vil du fortsette?(j/n): ");
				valg = ny.next();
				if(valg.equalsIgnoreCase("n")){
					choice = false;
					break;
				}
				next_kast = terning.roll();
				Sum = Sum + next_kast;
				System.out.println(Sum);
				Poeng[i] = Sum;


				if(Sum>21) {
					System.out.print(Spillere[i]);
					System.out.print(" tapte. ");
					choice = false;
					break;
				}
				if(Sum==21) {
					System.out.print(Spillere[i]);
					System.out.print(" vunnet. ");
					choice = false;
					break;
				}
			}

		}
		System.out.print("TEST");
	}
}

It would be awesome if some1 could help me out with this1 ;)

[Tolls]

Your Player class has static variables in there.
They should not be static, as that means there is a single name or points value for all Players.

Also I'm guessing the 'void Player()' is supposed to be a constructor, so remove the void, and you can skip the 'spiller.Player()' line later on.

Of course all that is on the assumption you are using the Player object called 'spiller', and there's no sign of that in omgang().

[OPTYMISTA]

Thanks for quick reply. When I changed variables in "Player class" to not be static, I've got an error in "omGang-method".

int Sum = Player.points;

. I suppose that i can't call variable form another constructor?

[PhHein]

Get rid of all the static stuff. Use an Array of Player in MainProgram. Iterate over the Array's elements and use the getter and setter methods for name and points.

Coding standards: variables and method names always start with lower case characters. Never name methods the same as the class name (player()).

[DarrylBurke]

OPTYMISTA, please go through the Forum Rules, especially the third paragraph.

db

[OPTYMISTA]

OPTYMISTA, please go through the Forum Rules, especially the third paragraph.

Sorry, it won't happen again... ;)

Now I've figured out how I refer each player object to different array-position. Such as . Now I want to do the same thing with points. I've written an extra statement in "omGang()" that says:

 return sum;

there sum is the assumed value of points after rolling dice.
I'm beginner and I want to understand what I'm doing, step by step. No matter if I sound like an idiot ;)) So thank YOU in advance for your attention to this matter.

[PhHein]

Uhm, a player object already encapsulates a name and a score (points). So you just have to add up the points of the current player.

[OPTYMISTA]

I think i didn't quite get what do you mean. I know that player object contains value "points", but I'm not sure how to use it.
Later I want to compare scores, so I can decide who wins. Shouldn't values of points for each player be saved in an new array (arrayPOINTS) then?

[Tolls]

Why?
If you have the two Player objects then simply compare the two points values held by them.

if (player1.getPoints() > player2.getPoints()) {
   System.out.println("Player 1 wins!");
} else {
   System.out.println("Player 2 wins!");
}

(Note I have ignored draws there...)