Making Triangles

I've been trying to fill stars and have random placement for a while now but I've only started doing triangles. This is my code but command prompt gives me an error having to do with my arrays for the x points. I'm not sure what's wrong and my teacher has no idea either. Someone please give me some explanation for this and some suggestions

Much appreciation.

Code:

---

import javax.swing.*;
import java.awt.*;
import java.util.Random;

public class PP4_12
{
        public static void main (String[] args)
        {
                JFrame frame = new JFrame ("");
                frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
               
                frame.getContentPane().add(new StarPanel());
               
                frame.pack();
                frame.setVisible(true);
        }
}

class StarPanel extends JPanel
{
        private Star s1;
       
        public StarPanel()
        {
                s1 = new Star();
               
                setPreferredSize(new Dimension(600, 400));
                setBackground(Color.darkGray);
        }
       
        public void paintComponent(Graphics page)
        {
                super.paintComponent(page);
               
                s1.draw(page);
        }
}

class Star
{
        private Polygon p1, p2, p3, p4 ,p5, p6;
        private Random rand;
        private int x;
        private int y;
        private int[] xPoints;
        private int[] yPoints;
       
        public void draw(Graphics page)
        {       
                page.setColor(Color.yellow);
               
                p1 = new Polygon();
               
                x = rand.nextInt(10)
                x = x*10;
                y = x;
                xPoints = {10+x, 10+x, 15+x}
                yPoints = {10+y, 20+y, 15+y}
                page.fillPolygon(xPoints, yPoints, 5);
        }
}

---

To get all that code working, you'll have to fix a few things.

1. Fix all the missing semicolons. In the end of your code they seem to be missing every second line or something.
2. You will get NullpointerException's if you don't initialize your variables. Fix this!

Tip:

Code:

---

        private Random rand = new Random(10);

---

You will also need to initialize your coordinates:

Code:

---

        private int[] xPoints = new int[3];

---

3. As far as I know, you can't do this:

Code:

---

        xPoints = {10+x, 10+x, 15+x}
        yPoints = {10+y, 20+y, 15+y}

---

It will give you some errors about how to use constants in the initializer.

You can always set them later:

Code:

---

                xPoints[0] = 10+x;

---

That should get you heading in a better direction I believe!

Quote:

---

Originally Posted by Zyril

To get all that code working, you'll have to fix a few things.

1. Fix all the missing semicolons. In the end of your code they seem to be missing every second line or something.
2. You will get NullpointerException's if you don't initialize your variables. Fix this!

Tip:

Code:

---

        private Random rand = new Random(10);

---

You will also need to initialize your coordinates:

Code:

---

        private int[] xPoints = new int[3];

---

3. As far as I know, you can't do this:

Code:

---

        xPoints = {10+x, 10+x, 15+x}
        yPoints = {10+y, 20+y, 15+y}

---

It will give you some errors about how to use constants in the initializer.

You can always set them later:

Code:

---

                xPoints[0] = 10+x;

---

That should get you heading in a better direction I believe!

---

Thanks, I ended up fixing it by mostly scrapping what I did. I did use a couple things from your reply though; it's working now:(nod):