Mistakes

Hello there. I am new to Java and have started making a programme. I hva eput the code into J creator but it doesnt work,. Are there any mistakes with the code below that I am missing.

public class one

public static void main(String args[]) {

int distancetraveled;
int fuelconsumed;
int resultmpg;
int resultkmpl;
int units;
int drivingtype;
int units;
int drivingtype;

System.out.println("How many miles have you traveled?");
distancetraveled=UserInput.readInt();

System.out.println("How much fuel have you consumed? Enter in gallons");
fuelconsumed=UserInput.readInt();

System.out.println("What unit would you like the results displayed in? for mpg enter 1 for kmpl enter 2");
units=UserInput.readInt();

if (units=1){
resultmpg=distancetraveled/fuelconsumed;
input='A';
}

else if (units=2){
resultkmpl=distancetraveled/fuelconsumed;
resultkmpl=resultkmpl*0.425143707
input='B';
}

else {
input='X';
}

switch( input ) {
case 'A': System.out.println("Your car does " + resultmpg +"MPG");
break;
case 'B': System.out.println("Your car does " + resultkmpl +" KMPL");
break;
case 'X': System.out.println("Incorrect Data Entered");
break;

}

System.out.println("Please enter your driving type urban = 1, motorway = 2, mixed = 3");
drivingtype=UserInput.readInt();

if (units=1 && resultmpg>=57 && drivingtype=1){
input='C';
}

else if (units=1 && resultmpg>=47 && resultmpg<57 && drivingtype=1){
input='D';
}

else if (units=1 && resultmpg <47 && drivingtype=1){
input='E';
}

else if (units=1 && resultmpg>=65 && drivingtype=2){
input='F';
}

else if (units=1 && resultmpg>=55 && resultmpg<65 && drivingtype=2){
input='G';
}

else if (units=1 && resultmpg<55 && drivingtype=2){
input='H';
}

else if (units=1 && resultmpg>=61 && drivingtype=3){
input='I';
}

else if (units=1 && resultmpg>=51 && resultmpg<61 && drivingtype=3){
input='J';
}

else if (units=1 && resultmpg<51 && drivingtype=3){
input='K';
}

else if (units=2 && resultkmpl>=20 && drivingtype=1){
input='L';
}

else if (units=2 && resultkmpl>=17 && resultkmpl<20 && drivingtype=1){
input='M';
}

else if (units=2 && resultkmpl<17 && drivingtype=1){
input='N';
}

else if (units=2 && resultkmpl>=23 && drivingtype=2){
input='O';
}

else if (units=2 && resultkmpl>=20 && resultkmpl<23 && drivingtype=2){
input='P';
}

else if (units=2 && resultkmpl<19 && drivingtype=2){
input='Q';
}

else if (units=2 && resultkmpl>=22 && drivingtype=3){
input='R';
}

else if (units=2 && resultkmpl>=18 && resultkmpl<22&&drivingtype=3){
input='S';
}

else if (units=2 && resultkmpl<18 && drivingtype=3){
input='T';
}

else {
input='Y';
}

switch( input ) {
case 'C': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent.");
break;
case 'D': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent.");
break;
case 'E': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent.");
break;
case 'F': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent.");
break;
case 'G': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent.");
break;
case 'H': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent.");
break;
case 'I': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent.");
break;
case 'J': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent.");
break;
case 'K': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent.");
break;
case 'L': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent.");
break;
case 'M': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent.");
break;
case 'N': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent.");
break;
case 'O': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent.");
break;
case 'P': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent.");
break;
case 'Q': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent.");
break;
case 'R': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent.");
break;
case 'S': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent.");
break;
case 'T': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent.");
break;
case 'Y': System.out.println("You have entered an incorrect value");
System.exit(0);

}

}

}

Re: Mistakes

When posting code, please use the code tags to preserve formatting.

You're going to have to be more specific than "it doesn't work" - what exactly does it do? Does it compile? Does it throw a runtime error? Does it exhibit some strange behavior? Does it become self-replicating and take over the ship, eventually achieving sentience and leaving you with a moral quandary of measuring your safety against the rights of the new lifeform?

Re: Mistakes

Quote:

Originally Posted by KevinWorkman

When posting code, please use the code tags to preserve formatting.

You're going to have to be more specific than "it doesn't work" - what exactly does it do? Does it compile? Does it throw a runtime error? Does it exhibit some strange behavior? Does it become self-replicating and take over the ship, eventually achieving sentience and leaving you with a moral quandary of measuring your safety against the rights of the new lifeform?

Hi Kevin. I havent even run it. I just put it into J creator and there are squiggly lines everywhere. I dont think I have set J creator up correctly. I was just hoping someone could have a quick browse throguh it and tell me if there are any glaringly obvious mistakes. Or even put it into J creator and tell me if it works. I think the J creator I have on my computer doesnt work.

Re: Mistakes

You have to use the '==' operator if you want to compare two numbers for equality, not one equal sign; variable UserInput isn't defined (as I can see) and I'm sure there are more errors ...

kind regards,

Jos

Re: Mistakes

@Benprice, if you try to compile it and there are syntax errors then it will spit out lines of errors. These errors are very helpful when you're trying to figure out where things when wrong. Try to compile your program and read your error message, if you are still stumped please post it here.

Also, I would urge you to take delete your code and paste it back in to code tags. Note, do not just wrap [code][/code] tags around your current code as there will be no formatting. Paste a fresh copy and paste from your JCreator.

I personally don't touch code unless its posted with formatting as it makes it incredibly more difficult to read your code. Don't be surprised when there are a lot of people here with the same mindset as people are here helping in their spare time and are not being paid to help out.

Re: Mistakes

sorry wrong code entered

Re: Mistakes

Code:

public class one { public static void main(String args[]) { int distancetraveled; int fuelconsumed; int resultmpg; int resultkmpl; int units; int drivingtype; int units; int drivingtype; System.out.println("How many miles have you traveled?"); distancetraveled=UserInput.readInt(); System.out.println("How much fuel have you consumed? Enter in gallons"); fuelconsumed=UserInput.readInt(); System.out.println("What unit would you like the results displayed in? for mpg enter 1 for kmpl enter 2"); units=UserInput.readInt(); if (units=1){ resultmpg=distancetraveled/fuelconsumed; input='A'; } else if (units=2){ resultkmpl=distancetraveled/fuelconsumed; resultkmpl=resultkmpl*0.425143707 input='B'; } else { input='X'; } switch( input ) { case 'A': System.out.println("Your car does " + resultmpg +"MPG"); break; case 'B': System.out.println("Your car does " + resultkmpl +" KMPL"); break; case 'X': System.out.println("Incorrect Data Entered"); break; } System.out.println("Please enter your driving type urban = 1, motorway = 2, mixed = 3"); drivingtype=UserInput.readInt(); if (units=1 && resultmpg>=57 && drivingtype=1){ input='C'; } else if (units=1 && resultmpg>=47 && resultmpg<57 && drivingtype=1){ input='D'; } else if (units=1 && resultmpg <47 && drivingtype=1){ input='E'; } else if (units=1 && resultmpg>=65 && drivingtype=2){ input='F'; } else if (units=1 && resultmpg>=55 && resultmpg<65 && drivingtype=2){ input='G'; } else if (units=1 && resultmpg<55 && drivingtype=2){ input='H'; } else if (units=1 && resultmpg>=61 && drivingtype=3){ input='I'; } else if (units=1 && resultmpg>=51 && resultmpg<61 && drivingtype=3){ input='J'; } else if (units=1 && resultmpg<51 && drivingtype=3){ input='K'; } else if (units=2 && resultkmpl>=20 && drivingtype=1){ input='L'; } else if (units=2 && resultkmpl>=17 && resultkmpl<20 && drivingtype=1){ input='M'; } else if (units=2 && resultkmpl<17 && drivingtype=1){ input='N'; } else if (units=2 && resultkmpl>=23 && drivingtype=2){ input='O'; } else if (units=2 && resultkmpl>=20 && resultkmpl<23 && drivingtype=2){ input='P'; } else if (units=2 && resultkmpl<19 && drivingtype=2){ input='Q'; } else if (units=2 && resultkmpl>=22 && drivingtype=3){ input='R'; } else if (units=2 && resultkmpl>=18 && resultkmpl<22&&drivingtype=3){ input='S'; } else if (units=2 && resultkmpl<18 && drivingtype=3){ input='T'; } else { input='Y'; } switch( input ) { case 'C': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent."); break; case 'D': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent."); break; case 'E': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent."); break; case 'F': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent."); break; case 'G': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent."); break; case 'H': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent."); break; case 'I': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly efficent."); break; case 'J': System.out.println("Your car does " + resultmpg +"miles per gallon and is efficent."); break; case 'K': System.out.println("Your car does " + resultmpg +"miles per gallon and is highly inefficent."); break; case 'L': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent."); break; case 'M': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent."); break; case 'N': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent."); break; case 'O': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent."); break; case 'P': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent."); break; case 'Q': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent."); break; case 'R': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly efficent."); break; case 'S': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is efficent."); break; case 'T': System.out.println("Your car does " + resultkmpl +"kilometres per litre and is highly inefficent."); break; case 'Y': System.out.println("You have entered an incorrect value"); System.exit(0); } } }

Re: Mistakes

JosAH gave you a couple of issues he spotted with a quick glance. Have you tried fixing them in your code yet?

Also what is your compiler throwing for an error when you try to compile it?

Re: Mistakes

Jos' has told you what's wrong with those if statements.

ETA: And today I will be pretending to be an echo...

Re: Mistakes

--------------------Configuration: one - <Default> - <Default>--------------------
Error : Invalid path, \bin\javac.exe -classpath "C:\Program Files\Xinox Software\JCreatorV4\MyProjects\one\classes" -d C:\Program" Files\Xinox "Software\JCreatorV4\MyProjects\one\classes @src_one.txt"

I am about to fix the errors he suggested.

Re: Mistakes

so to cover what Jos said i would chagne:

else if (units=1 &&

to

else if (units==1 &&

Re: Mistakes

Yes, that would be the correct syntax for comparing. Also he mentioned about userInput, do you have userInput defined anywhere? The code you posted here, if it is all of the code (which you should be posting in a Short, Self Contained, Correct Example if possible), does not have userInput defined before it is called.

Re: Mistakes

perfect I have fixed all of those. I have no idea how to define user input. is there an example of this you could show me? sorry I have never used a programming forum before I havent got a clue how to correctly post. appologies.

Re: Mistakes

Well first what is UserInput? What are you trying to make it do? Every object is defined a little different based on what its needed for.

Defining a variable is simple, such as an integer variable.

Code:

int i = 0;

That is a very common declaration used in programs, often found in loops it defines a variable to the type int and to the value of 0.
All About Java Variables

Re: Mistakes

I would point to the Java tutorials at Oracle, personally.
Variables (The Java™ Tutorials > Learning the Java Language > Language Basics)