how to kill a thread

hello , my code is like :

Quote:

---

import java.util.*;
class MyThread implements Runnable {
Scanner s = new Scanner (System.in);
String p ;
String threadname ;
Thread t ;

MyThread(String s1){
threadname = s1 ;
t = new Thread (this , threadname);
t.start();
}
public void run() {
System.out.println("Thread in to : " +Thread.currentThread().getName());
System.out.print("Enter name with in 5 seconds : ");
p = s.next();
}
}
public class threadassn {
public static void main(String args[])throws Exception{
MyThread m1 = new MyThread("My Thread 1");
try{
System.out.println("Running Thread Name :" +Thread.currentThread().getName());
Thread.sleep(5000);
}catch(Exception e){}

if((m1.p)==(null))
{
System.out.println("\nOops!!! time out!!!");
System.out.println(m1.t.isAlive());
// System.exit();
}
else
System.out.println("\n"+m1.p);
}
}

---

actually i have created a thread m1 in main and when main thread sleep() for 5 sec , i want to enter my name and if the user doesnot enter something within 5 sec i want this thread to stop , and my program should terminate .

everything goes well when i enter something in 5 sec it show the entered text after 5 sec but when i donot enter anything and wait for timeout , the execution waits for me to enter something after printing timeout i.e. the program actually holds at s.next() , i know that i can terminate the program by using System.exit() , but i want a different approach so that thread is killed at that very instant after 5 sec...

actually my concern is when i want to terminate OR kill a single thread like this out of some 10 threads in process


please help me with a solution and appropriate explaination

thanks in advance

Please use [code] [/code] tags when posting code, not [quote] [/quote] tags so that we can read and understand your code.

I'm no expert at "killing" threads, but have you tried putting code in the empty catch block and calling interrupt on the thread that you wish to kill? If so, what happens?

Code:

---


 import java.util.*;

 class MyThread implements Runnable
 {
    Scanner s = new Scanner (System.in);
    String p ;
    String threadname ;
    Thread t ;

    MyThread(String s1)
    {
    threadname = s1 ;
    t = new Thread (this , threadname);
    t.start();
    }

    public void run()
    {
    System.out.println("Thread in to : " +Thread.currentThread().getName());
    System.out.print("Enter name with in 5 seconds : ");
    p = s.next();
    }
 }

 public class threadassn
 {
    public static void main(String args[])throws Exception
    {
    MyThread m1 = new MyThread("My Thread 1");
    try{
          System.out.println("Running Thread Name :" +Thread.currentThread().getName());
          Thread.sleep(5000);
        }catch(Exception e){}

    if((m1.p)==(null))
    {
      System.out.println("\nOops!!! time out!!!");
      System.out.println(m1.t.isAlive());
      // System.exit();
    }
    else
    System.out.println("\n"+m1.p);
    }
  }

---

i didn't got it exactly please elaborate OR give the approriate code

actually i have created a thread m1 in main and when main thread sleep() for 5 sec , i want to enter my name and if the user doesnot enter something within 5 sec i want this thread to stop , and my program should terminate .

everything goes well when i enter something in 5 sec it show the entered text after 5 sec but when i donot enter anything and wait for timeout , the execution waits for me to enter something after printing timeout i.e. the program actually holds at s.next() , i know that i can terminate the program by using System.exit() , but i want a different approach so that thread is killed at that very instant after 5 sec...

actually my concern is when i want to terminate OR kill a single thread like this out of some 10 threads in process


please help me with a solution and appropriate explaination

thanks in advance

Your code is all left-justified making it hard to read. Is this how you normally format your code? Please edit and add indentations as this will make it possible for us to read it.

Here's a non-Scanner way of interrupting user input on the console: [JavaSpecialists 153] - Timeout on Console Input

Your thread will die eventually, as the run() method has exited.
There's not much more you can do.

Code:

---

import java.util.*;
 
class MyThread implements Runnable
{
  Scanner s = new Scanner (System.in);
  String p ;
  String threadname ;
  Thread t ;
 
  MyThread(String s1)
  {
  threadname = s1 ;
  t = new Thread (this , threadname);
  t.start();
  }
 
  public void run()
  {
  System.out.println("Thread in to : " +Thread.currentThread().getName());
  System.out.print("Enter name with in 5 seconds : ");
  p = s.next();
  }
}
 
public class threadassn
{
  public static void main(String args[])throws Exception
  {
  MyThread m1 = new MyThread("My Thread 1");
  try{
        System.out.println("Running Thread Name :" +Thread.currentThread().getName());
        Thread.sleep(5000);
      }catch(Exception e){}
 
  if((m1.p)==(null))
  {
    System.out.println("\nOops!!! time out!!!");
    System.out.println(m1.t.isAlive());
      // System.exit();
    }
    else
    System.out.println("\n"+m1.p);
    }
 }

---

i didn't got it exactly please elaborate OR give the approriate code

actually i have created a thread m1 in main and when main thread sleep() for 5 sec , i want to enter my name and if the user doesnot enter something within 5 sec i want this thread to stop , and my program should terminate .

everything goes well when i enter something in 5 sec it show the entered text after 5 sec but when i donot enter anything and wait for timeout , the execution waits for me to enter something after printing timeout i.e. the program actually holds at s.next() , i know that i can terminate the program by using System.exit() , but i want a different approach so that thread is killed at that very instant after 5 sec...

actually my concern is when i want to terminate OR kill a single thread like this out of some 10 threads in process


please help me with a solution and appropriate explaination

thanks in advance

Quote:

---

Originally Posted by know_how

actually i have created a thread m1 in main and when main thread sleep() for 5 sec , i want to enter my name and if the user doesnot enter something within 5 sec i want this thread to stop , and my program should terminate .

---

No, you have created a Runnable, m1, in your main method. The MyThread class is misleadingly named since it is not in fact a Thread, and the Thread object itself is held inside this class in variable "t".

DOH!
That was stupid of me...of course it hasn't exited.
It's sat waiting for Scanner input.

Quote:

---

Originally Posted by Tolls

Your thread will die eventually, as the run() method has exited.
There's not much more you can do.

---

His run() method has a blocking call on a Scanner object, and so will never die until input has been given by the user.

thanks