Help with ArrayList

[HalfAZN]

I've been assigned a program in which I make a Spy Class, each of which has certain perameters, including an array list of aliases. Furthermore, there are SpyRings, which contain spies. A final driver class prints out all elements of a spyring. When I attempt to print the SpyRing, it compiles w/ no errors, but prints nothing. Any help?

Here's the Spy Class:

import java.util.*;
public class Spy
{
	private String inname;
	private String inspyNum;
	private  static ArrayList<String> aliases;

public Spy(String spyNum, String name)
{
	inname=name;
	inspyNum=spyNum;
	aliases = new ArrayList<String>();
}

public String toString()
{
	return "Name: "+inname +" Number: "+inspyNum+" Aliases: "+aliases;
}

public static void addAlias(String newAlias)
{
	aliases.add(newAlias);

}

public String getName()
{
	return inname;
}

public String getSpyNum()
{
	return inspyNum;
}

public ArrayList<String> getAliases()
{
	return aliases;
}



}

Here's the SpyRing class:

import java.util.*;
public class SpyRing
{
	private static  ArrayList<Spy> Spies;
	private String incountry;


public SpyRing(String country)
{
	Spies = new ArrayList<Spy>();
	incountry=country;
}

public void addSpy(String spynum, String spyname)
{
	Spy x=new Spy(spynum, spyname);
	Spies.add(x);
}

public static ArrayList<Spy> getSpyList()
{
	return Spies;
}




}

Here's the driver class:

import java.util.*;
import cs1.Keyboard;
public class SpyRingMaker
{
public static void main (String[]args)
{

boolean contin=true;
boolean continuity=true;
int count=0;

while(contin)
{
	System.out.println("1. Enter a spy for your SpyRing");
	System.out.println("2. Print SpyRing");
	System.out.println("3. Quit");
	int choice=Keyboard.readInt();
	String sNum, sName;
	SpyRing Goldfinger= new SpyRing("Australia");
	switch(choice)xz
	{
		case 1:
		System.out.println("Enter the name of the Spy");
			sName=Keyboard.readString();
		System.out.println("Enter the Number of the Spy");
			sNum=Keyboard.readString();

		Goldfinger.addSpy(sNum, sName);
		Goldfinger.getSpyList().get(count);
		while(continuity)
		{
			System.out.println("1. Enter an alias for this spy");
			System.out.println("2. Done with this Spy");
			int choices=Keyboard.readInt();

			switch(choices)
			{
				case 1:
				System.out.println("Enter an alias");
					String sAlias=Keyboard.readString();
				Goldfinger.getSpyList().get(count).addAlias(sAlias);
				break;

				case 2:
				continuity=false;

				break;
			}
			count++;
		}

		break;

		case 2:

		for (Spy each: Goldfinger.getSpyList())
		{
     		System.out.println(each);
   		}

		break;

		case 3:
		System.out.println("Goodbye");
		contin=false;

		break;

		default:
		break;
	}
}

}


}

[Norm]

When I attempt to print the SpyRing, it compiles w/ no errors, but prints nothing

Where is the code that is trying to print the SpyRing? Are there any elements in the ArrayList to be printed? If not where does the code add any elements to the arraylist? If the code adds some elements to an ArrayList, is it the same ArrayList as the one being used for printing?

Try debugging the code by adding some println statements to show what is added, how many elements are in the arraylist after each add.

[HalfAZN]

Norm, I try to print the SpyRing in lines 54-61 of the Driver.

In answer to your second question, the SpyRing is an ArrayList of Spies, which contains an ArrayList of aliases. So yes, there are elements to be printed.

As for the last question, yes--I believe that the program is printing the ArrayList that I'm putting elements into

[Norm]

Did you try debugging the code by adding calls to the println method as I suggested?
Add a println in the constructors so you can see when they are called.

How many items are in the array list when you print it at different places in the code?

[kaydell2]

When I attempt to print the SpyRing, it compiles w/ no errors, but prints nothing.

When I compile, I get some warnings. I suggest that you compile with warnings turned on and try to understand the warnings. Fixing your code to make all warnings go away often fixes bugs that make it past the compiler.

[HalfAZN]

Did you try debugging the code by adding calls to the println method as I suggested?
Add a println in the constructors so you can see when they are called.

How many items are in the array list when you print it at different places in the code?

While doing as you suggested, I ran into an issue. When adding a second alias, I get an indexOutOfBoundsException while running the program. Not sure what's causing it

[Norm]

I get an indexOutOfBoundsException

Where does it happen, what is the value of the index and how long is the item that is being indexed?
The cause is the index's value is too big for the item being indexed.

[HalfAZN]

It happens when adding a second element to the Aliases ArrayList.

[Norm]

Please post the full text of the error message.