Adding an array to an arraylist

[drakeramoray]

Here is my code:

public class Gameprj{
    public static void main(String args[])
    {
         ArrayList<int[]> al=new ArrayList<int[]>();
        int a[]={1,2,3,4};
        al.add(a);
        a[0]=5;
        a[1]=6;
        a[2]=7;
        a[3]=8;
        al.add(a);
        for(int[] ar: al)
        {
            for(int k=0;k<a.length;k++)
            {
            System.out.print(ar[k]+" ");
            }
           System.out.println(); 
         }
        
        
        
    }
}

I get the output as

5 6 7 8
5 6 7 8

Shouldn't it be
1 2 3 4
5 6 7 8

What am I doing wrong?

[pbrockway2]

Also at Java Programming Forums.

@drakeramoray: If you are going to start a discussion at multiple places it would be good if you posted links at each of them to the others. That way everybody taking part in the discussion knows what else is being said. You should be aware that some people will not respond to cross posts for fear of wasting their time on something that has been satisfactorily addressed elsewhere, or where the discussion might have moved off in some other direction.

[eRaaaa]

Yes if you would create/add a new array after line 6 (a = new int[a.length];)
Internal, the arraylist only references to the object/array a. With a[0] = .. you only change this array, but the reference is still the same (references to the same array/object).
If you print the toString of the arraylist -> System.out.println(al); you will see, both objects which are added to the list, are the same

[kaydell2]

You're using the same array named "a" to put into the ArrayList twice. When you add values to the array the second time, you're replacing the values that you added the first time. Before you add elements to the array the second time, try the following line of code:

a = new int[4];

This will create new array. This will work, but it would be easier to understand if you used a different variable name for the array than using "a" both times.

[drakeramoray]

Yes if you would create/add a new array after line 6 (a = new int[a.length];)
Internal, the arraylist only references to the object/array a. With a[0] = .. you only change this array, but the reference is still the same (references to the same array/object).
If you print the toString of the arraylist -> System.out.println(al); you will see, both objects which are added to the list, are the same

Thanks a lot:)...that worked right:)

[drakeramoray]

You're using the same array named "a" to put into the ArrayList twice. When you add values to the array the second time, you're replacing the values that you added the first time. Before you add elements to the array the second time, try the following line of code:

a = new int[4];

This will create new array. This will work, but it would be easier to understand if you used a different variable name for the array than using "a" both times.

Sure:)...Thanks for the help:)..that worked right:)