help with exceptions

[dawnMist]

It does, but the test still fails.
Still on the same line - method MyStorage.store() threw unexpected CannotStoreException() - error during storing data in remote server. It relates to the situation, where Connection.sendData() throws exception for the first time and succeds on the second time.

[Tolls]

Stick some debugging lines in there (println() calls) so you can see where in the flow it is going, because as it stands that code looks OK to me.
You'll want println() calls throughout that method, including the values of various variables (like retry and maxTries).

[dawnMist]

I tried to print retries and maxAttempts as last two commands, but they were strangely always 1.
Anyways thanks you so much for your help.
Just if you see anything in these two pieces of code, let me know.
Here is my code:

public class MyStorage implements Storage {
    private Connector connector;    
    private int maxAttempts;
    private Connection conn;
    private int retries = 1;
    
    public MyStorage(Connector connector, int maxAttempts) /*throws NullPointerException, IllegalArgumentException*/ {
        
        if(connector == null) throw new NullPointerException("connector");        
        if(maxAttempts < 1) throw new IllegalArgumentException("maxAttempts");
        
        this.connector = connector;
        this.maxAttempts = maxAttempts;
    }

    public void store(String host, Object data) throws DbException {
        try {
            Connection conn = connector.getConnection(host);
            conn.sendData(data);
        } catch (UnknownHostException e) {
            throw new DbUnreachableException("", e);
        }
          catch (NoRouteToHostException e) {
            throw new DbUnreachableException("", e);
        }
          catch (IOException e) {
            throw new CannotStoreException("", e);
        }   
                
        while(retries < maxAttempts) {
            try {
                conn.sendData(data);
                break;
            } catch (IOException e) {
                retries++;             
                if(retries == maxAttempts) throw new CannotStoreException("", e);
            }
        }
        
        System.out.println(retries);
        System.out.println(maxAttempts);
    }  
}

Here is the test, where it fails (lines 8-12):

        // test sending data with error and retry is ok
        connector = new TestConnector();
        st = new MyStorage(connector,2);
	connector.dataException = new IOException();
	connector.dataExceptionCounter = 1;
	try {
            st.store("address1", circle);
	} catch (Exception ex) {
	    fail("Methoda MyStorage.store() threw unexpected exception " 
		    + ex + " (it relates to the situation, where method " +
		    "Connection.sendData() throws exception for the first time and succeeds " +
		    "for the second time)");
	}
	assertEquals("Pri posilani gr. objektu na vzdaleny server nebyl objekt predan konektoru",
		circle,connector.sentData);
	assertEquals("Spojeni nebylo navazano se spravnou adresou","" +
		"address1",connector.host);
	assertEquals("Metoda Connector.getConnection() byla zbytecne volana vicekrat",
		1,connector.getConnectionCounter);
	assertEquals("Metoda Connection.sendData() byla zbytecne volana vicekrat",
		2,connector.sendDataCounter);

[Tolls]

Declare retries in the method itself, not as an attribute of the class, and initialise it to zero.

[dawnMist]

Same result. Well, it seems I will have to be hoping for a miracle here. :-)
But you have been a great help. Again, thank you so much.

[Tolls]

It could the test case is wrong, of course...

[dawnMist]

It´s not, I specifically asked. :-)

[Tolls]

Ah.
You're still calling sendData in your first try/catch block.
Remove that one, as the following while loop is now supposed to be handling all calls for that.

[dawnMist]

But that is for the first time test of sending data. I can´t remove this line, because there would be no object to pass to the connector and the first test would fail.

[Tolls]

That line needs to be removed for your code to follow the requirements.
At the moment you are always going to sendData twice at least.

[Tolls]

Oh yes, I see the problem:

Connection conn = connector.getConnection(host);

That is declaring a new, local, 'conn' variable, which is not the one help by your MyStorage class as an attribute.
If you remove the 'Connection' you will be assigning the result of getConnection() to your proper attribute.

[dawnMist]

I really appreciate your help with this. But it´s not that either. Still it does not pass the object when I dont put the sendData method in the first try block and when I put it in there, it throws the Exception where it should succeed (for the second time).

EDIT: OMG - you were right, I removed the sendData from the first try block AND I had to put my number of retries (iterator) = 0, I had "retries = 1;".
Now it works perfectly. Thank you so much for your help, you are a saint.