variables in loops

[mbw290]

I am learning loops and this is what I need to do. Essentially ask user for some numbers and get an average. Then I need to ask them if they'd like to enter another set. I cannot use arrays and have some code here.

 try
    {
      numAB = Integer.parseInt (AB);
      numHits = Integer.parseInt (hits);
      System.out.println (numAB);
      System.out.println (numHits);
      System.out.print ("Enter another player :");
      	option=bufferedReader4.readLine();
	if (numHits>numAB){
	System.out.println("You are a dumbass!!");
	System.exit(1);
	}
		if (option=="yes"){
			      System.out.print ("Enter  name: ");
      bufferedReader1 =
      new BufferedReader (new InputStreamReader (System.in));
      lastName = bufferedReader1.readLine ();
      System.out.print ("Enter at bats: ");
      bufferedReader2 =
      new BufferedReader (new InputStreamReader (System.in));
      AB = bufferedReader2.readLine ();
      System.out.print ("Enter hits: ");
      bufferedReader3 =
      new BufferedReader (new InputStreamReader (System.in));
      hits = bufferedReader3.readLine ();
		}

[Tolls]

Why are you creating a new reader for each input?
You only need one.

[mbw290]

Well before the try I needed to store Name NumAB num

[Tolls]

But you have 4 buffered readers, all referring to System.in.
You only need one.

Your indenting could do with tidying up, as it's not the easiest thing to follow at the moment.
And what does it do at the moment?

[mbw290]

It takes user input for a baseball player's name number of hits and number of at bats. There is another method to calculate the average of the numAB/numHits to get their batting average

import java.io.*;
import java.lang.*;
import java.util.*;
import java.text.*;
public class Baseball
{
    public static void main (String[]args) throws IOException
    {
        BufferedReader bufferedReader;
        BufferedReader bufferedReader1;
        BufferedReader bufferedReader2;
        BufferedReader bufferedReader3;
        BufferedReader bufferedReader4;
        bufferedReader = new BufferedReader (new InputStreamReader (System.in));
        String firstName;
        String lastName;
        String AB;
        String hits;
        String option;
        int numAB = 0;
        int numHits = 0;
        System.out.print ("Enter name: ");
        bufferedReader1 =
        new BufferedReader (new InputStreamReader (System.in));
        lastName = bufferedReader1.readLine ();
        System.out.print ("Enter at bats: ");
        bufferedReader2 =
        new BufferedReader (new InputStreamReader (System.in));
        AB = bufferedReader2.readLine ();
        System.out.print ("Enter hits: ");
        bufferedReader3 =
        new BufferedReader (new InputStreamReader (System.in));
        hits = bufferedReader3.readLine ();
        //System.out.println(firstName+" "+lastName+" "+AB+" "+hits+" "+option);
        try
        {
            numAB = Integer.parseInt (AB);
            numHits = Integer.parseInt (hits);
            System.out.println (numAB);
            System.out.println (numHits);
            if (numHits>
            numAB)
            {
                System.out.println("You are a dumbass!!");
                System.exit(1);
            }
        }
        catch (NumberFormatException e)
        {
            System.out.println (AB);
            System.out.println (hits);
        }
        float Average = getAverage ((float) numHits, numAB);
        DecimalFormat formatter = new DecimalFormat (".###");
        System.out.println (formatter.format (Average));
    }
    public static float getAverage (float numHits, float numAB)
    {
        float Average = numHits / numAB;
        return (Average);
    }
}

[Tolls]

Step 1 is strip out those other readers and just use the single 'bufferedReader' for all your reading.

Second, for the average, at some point you need a 'total' and a 'count'.
So your loop needs to go round a number of times equal to the number of numbers the user is to enter (that is the 'count').

[mbw290]

I will try one buffered reader, but how do I print the results for the user then ask them if they want to enter another player (y or n) and continue or stop based on their answer.


It is dividing hits/at bats so no counter is necessary.

[Tolls]

Sorry, I misunderstood your original post.
OK, so the average is working then.

You need a loop, probably do-while, which will continue until the user enters 'n'.

DO
   Get player details
   Ask user if want to enter another one.
WHILE answer equals 'y'

That's the basic flow.

[mbw290]

Would this be in the try statement?

[Tolls]

The loop needs to cover asking the user for input, which seems to happen outside your try/catch block.

[mbw290]

am I missing something obvious?

import java.io.*;
import java.lang.*;
import java.util.*;
import java.text.*;
public class Baseball
{
    public static void main (String[]args) throws IOException
    {
	     
        BufferedReader bufferedReader1;
        BufferedReader bufferedReader2;
        BufferedReader bufferedReader3;
        BufferedReader bufferedReader4;
        String lastName;
        String AB;
        String hits;
	String user;
        boolean option;
        int numAB = 0;
        int numHits = 0;
	do
        System.out.print ("Enter name: ");
       bufferedReader1 =new BufferedReader (new InputStreamReader (System.in));
        lastName = bufferedReader1.readLine ();
        System.out.print ("Enter at bats: ");
        bufferedReader2 =       new BufferedReader (new InputStreamReader (System.in));
        AB = bufferedReader2.readLine ();
        System.out.print ("Enter hits: ");
        bufferedReader3 =        new BufferedReader (new InputStreamReader (System.in));
        hits = bufferedReader3.readLine ();
	while (user=="y")
	option=true;
	
	if (option=true){
        try
        {
            numAB = Integer.parseInt (AB);
            numHits = Integer.parseInt (hits);
            System.out.println (numAB);
            System.out.println (numHits);
            
	       float Average = getAverage ((float) numHits, numAB);
        DecimalFormat formatter = new DecimalFormat (".###");
        System.out.println (formatter.format (Average));

        }
}

        catch (NumberFormatException e)
        {
            System.out.println (AB);
            System.out.println (hits);
        }
        

 System.out.print ("enter option");
        bufferedReader4= new BufferedReader (new InputStreamReader (System.in));        user=bufferedReader4.readLine();
	
        

    }

    public static float getAverage (float numHits, float numAB)
    {
        float Average = numHits / numAB;
        return (Average);
    }
}

[quad64bit]

Your do-while is missing {}