Printable View
Thanks god it's working I love you.
edit:
For moving the picture smoothly an fast I did something like that:
It moves fast but I see the picture before the loop and after and not in every iteration of the loop.Code:if(arg0.getKeyCode() == KeyEvent.VK_LEFT)
{
for(int k=0;k<10;k++)
{
this.posX -= 1;
repaint();
}
}
Do you know why?
btw I'm doing it because moving pixel by pixel is very slow.
I have been called many things in my life, but god wasn't one of those... :(giggle): Glad that you got it working.Quote:
Originally Posted by tnrh1
That's because you are trying to do GUI/painting stuff while you are on the infamous EDT. You can either move the workload using the earlier mentioned Swing timer or just do this.posX -=10;
The diffrence between a good video camera to a bad one is the amount of pictures it takes in a second.
Doing this " this.posX -=10;" will reduce it. I want to see my picture moving every single pixel on the screen BUT after 1 click it will move something like 10 pixels 1 by 1.
Nice analogy. :) Go for the Swing Timer solution then, like Darryl Burke suggested in post #6.
I think you mean EDT.Quote:
Originally Posted by SurfMan
True. It's been a long day :)Quote:
Originally Posted by Tolls
I'm trying to use the Timer class in my game but I can't figure out how to use it correctly.
I got the same result as I mentioned above.
Code:public class MyPanel extends JPanel implements KeyListener
{
private Timer timer;
private Image img1;
private int posX;
private int posY;
private ActionListener al;
public MyPanel()
{
this.addKeyListener(this);
this.posX = (getPreferredSize().width/2)-(29/2);
this.posY = getPreferredSize().height-70;
this.img1 = getToolkit().getImage("kenny.gif");
this.setFocusable(true);
al = new ActionListener() {
@Override
public void actionPerformed(ActionEvent e)
{
repaint();
}
};
timer = new Timer(100,al);
timer.setInitialDelay(1);
timer.start();
}
public void paint(Graphics g)
{
super.paint(g);
g.drawImage(this.img1, this.posX, this.posY, null);
}
public Dimension getPreferredSize()
{
return new Dimension(900,900);
}
@Override
public void keyPressed(KeyEvent arg0)
{
if(arg0.getKeyCode() == KeyEvent.VK_LEFT)
{
for(int k=0;k<10;k++)
{
this.posX -= 1;
//repaint();
}
}
else
{
this.posX += 1;
//repaint();
}
}
@Override
public void keyReleased(KeyEvent arg0) {
// TODO Auto-generated method stub
}
@Override
public void keyTyped(KeyEvent arg0) {
// TODO Auto-generated method stub
}
}
Nitpick: you should override paintComponent, not paint.
But you aren't using the Timer how we're implying you should. Simply calling repaint() isn't enough. You need to move your image in the Timer.
Actually, you should set up a game logic function. In that game logic function, you should check which keys are pressed, and move the sprite accordingly, then call repaint(). Then all you have to do is call that function from a Timer repeatedly - 30 times a second is a good starting point.
I do have that kind of function, the key pressed function "check which keys are pressed, and move the sprite accordingly, then call repaint()".
Then you say that I need to call that function from a timer, what do you mean?how can I call to another function from a timer?timer is an instance not a function.
I think I got you wrong.
No, the KeyListener is only called when the user presses a key. That's going to make it hard to do things like animations, game logic, etc.
Instead, simply update a set of booleans that tell you which keys are pressed from the KeyListener. Then from the Timer, call a function that updates the state of the game based on those booleans. That way you can do smooth animations over time instead of only when the user presses a key.
Ok so generally your suggestion is to repaint every x time if some kind of boolean that represent a key pressed is true, right?
Now the only thing I still don't understand is "Then from the Timer, call a function that updates" how can I call with a timer instance to a function that written in another class?
I mean from the Timer's ActionListener's actionPerformed() method. The skeleton of your game will look something like this:Quote:
Originally Posted by tnrh1
Code:class Game extends JPanel{
private boolean upPressed;
//booleans for down, left, right, etc
public Game(){
//initialize, background color, etc
addKeyListener(new KeyListener(){
public void keyPressed(KeyEvent e){
if(e.key ==up){
upPressed = true;
}
//logic for other keys
}
public void keyReleased(KeyEvent e){
if(e.key == up){
upPressed = false;
}
//logic for other keys
}
});
Timer t = new Timer(32, new ActionListener(){
public void actionPerformed(ActionEvent e){
update();
}
});
t.start();
}
public void update(){
if(upPressed){
//move image up
}
//check other booleans, update game
repaint();
}
public void paintComponent(Graphics g){
//paint your game
//no game logic here! Just painting!
}
}
It's working now perfectly but instead of overriding paintComponent I overrided paint since it got the first error i had in #1
Just wanted to tell you how much I appreciate your help and support and that the reason why I want to help other people and promoting this amazing forum.
No problem. But you should really stick with overriding paintComponent() and not paint(). The paint() method handles things like double buffering, so you should leave it alone. Stick with paintComponent, and just make sure you have the call to super in there as the first line.Quote:
Originally Posted by tnrh1
ooooops I called to super.paint instead of super.paintComponent, it's working now as you said :)
Yeah, I think so. I do all of my drawing in a component (JPanel subclass) inside the paintComponent method, so in that case the syntax is correct - but if using just the "paint()" method, then a call to the super's paint method makes more sense.Quote:
Shouldn't that be just super.paint() instead of super.paintComponents()?