How can I count "trues" in an array?

[kkid]

I have arrays and I want to count the amount of times the boolean variable "isBooked" is true across them all.


At the moment, I am trying to do this using a method where I enter the array name and an if statement (in conjunction with an index) will run through each variable in the array increasing another variable "count" if it is true.

However, I am getting syntax completely wrong I think, I haven't done much work with arrays so do not understand them fully yet.



This is my (rough) code for this:

    public static void seatsBooked(AtoCSeat row){
        
        int count = 0;
        int index = 0;
        
        if (row[index].isBooked = true){
            count ++;           
        }
        index ++;
        
    }

I would put in a limiter to stop the index increasing forever, but what am I doing wrong?


note: AtoCSeat is the data type (object) of each variable. isBooked is declared in the objects.

[KevinWorkman]

I believe you are looking for a for loop.

[kkid]

I believe you are looking for a for loop.

I haven't use them yet, I'll go research.

Also, I forgot to mention, I was getting an alert in NetBeans saying "array required, but no AtoCSeat found"

[kkid]

I have just looked up for loops and replaced my if loop with it but I still get the same alert in NetBeans

[quad64bit]

Could you show use the complete stack trace error and show use the line of code where it occurs?

[kkid]

I haven't actually compiled it, I was just getting an alert on the line number in NetBeans.

I'll try that now.


Should I code I put above work in theory then?

[quad64bit]

Alerts are only alerts, not errors. If all you get is an alert, then you can ignore it! :D

[kkid]

I worked it out!!!




I worked backwards through my program and realised I needed to put the input type of the parameter of he method as an array of AtoCSeat (AtoCSeat[]) instead of just an AtoCSeat.

i.e.

public static void seatsBooked(AtoCSeat[] row){

[quad64bit]

Oh yeah! Good catch!

[kkid]

Oh yeah! Good catch!

haha thanks



I'm stuck on the final part of this though. I don't understand why it isn't working.

This is the code relating to the counting of "trues":

    public static int seatsBookedRow(AtoCSeat[] row){
       
        
        int count = 0;
        int index = 0;
        
        while(index < row.length){
        
        if (row[index].isBooked = true){
            count ++;           
        }
        index ++;
        
        }
        
        return count;
    }
    
    
    public static int seatsBookedTotal(){
        return (seatsBookedRow(A) + seatsBookedRow(B) + seatsBookedRow(C) + 
                seatsBookedRow(D) + seatsBookedRow(E) + seatsBookedRow(F) + 
                seatsBookedRow(G) + seatsBookedRow(H) + seatsBookedRow(J) +
                seatsBookedRow(K) + seatsBookedRow(L));
        
    }

I've been working on this program solidly for around 8 hours now so am going to leave it after this


Can anybody see what is wrong with the above?

[Tolls]

        if (row[index].isBooked = true){

You're not checking the boolean there.
You're setting it to true.

Get rid of the '= true', since it's unecessary.

[Kagiso]

I am not sure about the line

if (row[index].isBooked = true) // whenever i see a single = sign i tend to think it's a assignment statement

try writing it like this
if(row[index].isBooked) // or if you still feel like using the equal sign you should write it like this:
if(row[index.isBooked == true)

[kkid]

ah, yes!

but it still isn't working.

i get this error:

Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - Erroneous tree type: <any>
at BookingsSystem.seatsBookedTotal(BookingsSystem.jav a:158)
at BookingsSystem.viewStatistics(BookingsSystem.java: 105)
at BookingsSystem.userInterface(BookingsSystem.java:8 2)
at BookingsSystem.main(BookingsSystem.java:11)
Java Result: 1

[KevinWorkman]

And what code is one line 158 of BookingsSystem?

For better help faster, you should boil your problem down to an SSCCE and post it in its entirety. Also, you should be compiling very often, not waiting until you think you have the whole program written.

[kkid]

158 is the return statement:

return (seatsBookedRow(A) + seatsBookedRow(B) + seatsBookedRow(C) + seatsBookedRow(D) + seatsBookedRow(E) + seatsBookedRow(F) + seatsBookedRow(G) + seatsBookedRow(H) + seatsBookedRow(J) +seatsBookedRow(K) + seatsBookedRow(L));

Netbeans is alerting me to that line too (I have made it all one line now), it says it can't find variable A, B, C, D etc...

[kkid]

I did realise I needed to add more methods (because if D is entered, this isn't an AtoCSeat for example.


This is the total code now for this part of the program:

    public static int seatsBookedRow(AtoCSeat[] row){
       
        
        int count = 0;
        int index = 0;
        
        while(index < row.length){
        
        if (row[index].isBooked){
            count ++;           
        }
        index ++;
        
        }
        
        return count;
    }
    
    
    public static int seatsBookedRow(DtoFSeat[] row){
       
        
        int count = 0;
        int index = 0;
        
        while(index < row.length){
        
        if (row[index].isBooked){
            count ++;           
        }
        index ++;
        
        }
        
        return count;
    }
        
        
    public static int seatsBookedRow(GtoLSeat[] row){
       
        
        int count = 0;
        int index = 0;
        
        while(index < row.length){
        
        if (row[index].isBooked){
            count ++;           
        }
        index ++;
        
        }
        
        return count;
    }
    
    
    public static int seatsBookedTotal(){
        return (seatsBookedRow(A) + seatsBookedRow(B) + seatsBookedRow(C) + seatsBookedRow(D) + seatsBookedRow(E) + seatsBookedRow(F) + seatsBookedRow(G) + seatsBookedRow(H) + seatsBookedRow(J) +seatsBookedRow(K) + seatsBookedRow(L));
        
    }

[kkid]

I think I may have the solution (don't know how to fix it yet, am only posting as I work it out.

there is no such variable in this method as A, B, C etc...

I need to link it somehow with the variables referring to the seat objects

[kkid]

ok, ive declared A, B, C etc... as static variables outside of any methods and this seems to have shut NetBeans up :P

However I still get an error when compiling:

Exception in thread "main" java.lang.NullPointerException
SOME TEXT WHICH SHOULD BE PRINTING (I PUT IT HERE)
at BookingsSystem.seatsBookedRow(BookingsSystem.java: 142)
at BookingsSystem.seatsBookedTotal(BookingsSystem.jav a:192)
at BookingsSystem.viewStatistics(BookingsSystem.java: 101)
at BookingsSystem.userInterface(BookingsSystem.java:7 8)
at BookingsSystem.main(BookingsSystem.java:25)
Java Result: 1

[kkid]

Would it be best to attach all of my program (its not too big) to a post?

[Tolls]

That's not a compilation error, that's a runtime error.
line 142 of your BookingSystem is throwing a NullPointerException, which means you haven't initialised something on that line.