HashMap key from arrayList

[Lund01]

I program a lot more these days.
And I figured out so many things om my own.
Got my program almost completly finished after 2 weeks of working on it, but this one thing here keeps annoying me right now.
(And my Java programming buddies are free today and tomorow).

The problem is:

I have keys storred in an arrayList.
But I also have a HashMap with a bunch of keys and some are the same and others aren't.

Like:
fileData2a = my arrayList with keys.
mapFile1 = Hashmap.

And I would like to know how do I get the ones who are the same printed on my screen for now.
Then I can process them further.

 
				// Get the keys from the arrayList (fileData2a). 
				for (int i = 0; i < fileData2a.size(); i++) {
					System.out.println(mapFile1.get(fileData2a));  
				}

I only get null null null in return.

Now I feel so silly for asking this if you would know what huge program I just made..... -_-

[DarrylBurke]

I have keys storred in an arrayList.
But I also have a HashMap with a bunch of keys and some are the same and others aren't.

The same instance or semantically equal? If the latter, does the class used for the list and the map keys override Object's equals(...) and hashCode() correctly?

To get better help sooner, post a SSCCE (Short, Self Contained, Correct (Compilable), Example) that demonstrates the problem. Not all your code, just enough to show the problem.

db

[Tolls]

Get the Set of keys from the HashMap.
Loops round either them or the List and do a contains() on the other one.

[JosAH]

Get the Set of keys from the HashMap.
Loops round either them or the List and do a contains() on the other one.

Loops, *yuck*; better construct a Set out of that List and retainAll( ... ) elements that are also in the keySet() of that Map; we don't need no stinkin' loops.

kind regards,

Jos

[Tolls]

You do realise that the Collection(Collection) constructor iterates over the parameter?
:)

[JosAH]

You do realise that the Collection(Collection) constructor iterates over the parameter?
:)

It does? Really? I want my money back! Fraud! It's a shameless fraud I'm telling you! Oh, I feel so disappointed ...

kind regards,

Jos ;-)

[Lund01]

I now have this:

 
				for (int i = 0; i < ArrayListFileData2.size(); i++) { 

					// Get the data out of the arrayList. 
					String ArrayKey2 = ArrayListFileData2.get(i).toString(); 
					// Get the keys from the HashMap, mapFile1. 
					Set keys = mapFile1.keySet(); 
					//System.out.println(keys);
					
					if (ArrayKey2.equals(keys)) {
						System.out.println("Right!");
					}
					else {
						System.out.println("Not");
					}
					
				}

I now do have found a way to get the keys out of the HashMap.

But I only get "Not" as the result.
While some are the same.

[Tolls]

You're comparing a String to the Set of keys.
You want to simply use keys.contains().

[Lund01]

So I changed that part you said.

 
				Set keys = mapFile1.keySet(); 
				
				// Get the keys from the arrayList (ArrayListFileData2). 
				for (int i = 0; i < ArrayListFileData2.size(); i++) { 

					// Get the data out of the arrayList. 
					String ArrayKey2 = ArrayListFileData2.get(i).toString(); 
					
					//
					if (keys.contains(ArrayKey2)) {
						System.out.println("Right!");
					}
					else {
						System.out.println("Not"); 
					}
					
				}

And then I still get more "Not", not one "Right!"

[Tolls]

What are the keys to the Map?
And, for that matter, what does the ArrayList contain?

You really need to use generics.

[Lund01]

I have added some System.out.print() statements, and I think he looks at the whole set of keys if it all matches with a single ArrayKey2.
Like:
ArrayKey2 = 4.0
keys = [4.0, 1.0, 11.0, 48.0]

Could that maybe also be it?

[Tolls]

No.
What are the keys and what does the ArrayList contain?
If they are Integers then using a String to find them will not work as they will not match....ever.

[Lund01]

ArrayList<Cell> ArrayListFileData2 = new ArrayList<Cell>();

Map<Cell, XSSFCell> mapFile1 = new HashMap<Cell, XSSFCell>()

In the arrayList is data that I took from certairn cells from an excel file.
For that I used Apache POI.

So both are <Cell>

[DarrylBurke]

What determines the semantic equality of two Cells? Is it only the value? Check the API for the class.

db

[Tolls]

You are not comparing Cells though (even if they have valid equals and hascode methods).

String ArrayKey2 = ArrayListFileData2.get(i).toString();

You turned your Cell into a String...so it's never going to match.

[Lund01]

I changed my code, so now they are both Objects.
And it grabs one key from the arrayList and it matches that against the keys from the HashMap keys, one at the time.

Still t won't match.
Ths drives me crazy...

// Get keys from hashMap1
				Set keys = mapFile1.keySet(); 
				//
				Iterator keyIterator = keys.iterator(); 
				
				// Get the keys from the arrayList (ArrayListFileData2). 
				for (int i = 0; i < ArrayListFileData2.size(); i++) { 
					
					//System.out.print(ArrayListFileData2.get(i) + " ");

					Object ArrayKey2 = ArrayListFileData2.get(i); 

					//System.out.println(keys);
					
					while(keyIterator.hasNext()) {
						Object keyObj = keyIterator.next();
						System.out.println( "Key: " + keyObj);
						
						if (ArrayKey2.equals(keyObj)) {
							System.out.println("Ja"); 
						}
						else {
							System.out.println("Nee");
						}
					}

All but one should have as output "Ja".
But everything is still "Nee".

[Tolls]

Use GENERICS!
For gods sake.
That would solve any potential mismatches between types.
Then we would at least know what these types were when looking at your code.
It's not as if the compiler won't be warning you.

Now assuming these are Cells, then you probably need to answer Darryl's question. What makes a Cell equal?

[Lund01]

I added the generics.
And now I have it working for one part.
It does match and it does that coorectly.
Only thing is, it only grabs the first entry from the arrayList.
So I only have to solve that part now.

Thanks for the help. :)