My Checkbox program is not working properly

[newbie106]

Hi,
I'm new to java and I made a program that creates an oval and asks the user whether it should be filled or not. The checkbox starts checked just like I programmed it to be but when I click it, it does not check off however, the oval becomes unfilled. What's the problem?

My code is:
private JCheckBox checkbox;
checkbox = new JCheckBox("Filled");
checkbox.setSelected(true);
add (checkbox, SOUTH);

is there anything I need to add so the box would uncheck when I click it?

[Fubarable]

An ActionListener would probably help out a lot. Check out the buttons Swing tutorial for more on this.

[kammce]

So you have a listener on the JCheckBox? it works when you attempt to uncheck it but it does not check off when you click it? are you getting any weird console feed back. Your listener is working since it becomes unfilled, but your component is not responding.

Provide the console output if there is any and also provide the checkbox listener code (itemStateChanged).

[newbie106]

Well the function works just fine its just that when I click it it does not change from checked to unchecked. The full code is:

import acm.graphics.*;
import acm.program.GraphicsProgram;

import javax.swing.*;

import java.awt.event.*;
public class InteractiveOvals extends GraphicsProgram {
private JCheckBox checkbox;
public void init(){
checkbox = new JCheckBox("Filled");
checkbox.setSelected(true);
add (checkbox, SOUTH);
addMouseListeners();
addActionListeners();
}

public void mouseClicked(MouseEvent e){
GOval obj;
double diam = 40;
if(checkbox.isSelected()){
obj = new GOval(diam, diam);
obj.setFilled(true);
} else {
obj= new GOval(diam, diam);
obj.setFilled(false);
}
add (obj, e.getX(), e.getY());
}


}

you can try it if you want, but I used the acm library because it is easy and I just started learning.

[DarrylBurke]

<rant>Why do so many people think a forum devoted to Java can help them with code that uses classes not part of the JDK?</rant>

Most of us don't have (nor want to have) the acm library. Maybe you should ask your question wherever you got it.

Additionally, go through these:
Forum Rules
Guide For New Members
BB Code List - Java Programming Forum

db

[newbie106]

Well, I'm not asking for help regarding the acm library. All what the acm library does is that it creates the oval and sets it to be filled or not and there's no problem with that. The part of the code that I'm asking for help with is the JCheckBox part which is in javax library that is part of the JDK. So I don't know what the problem with the acm library is or why you're angry! The entire problem is that the checkbox icon does not change when I click it.
P.S if I posted this where I got the acm library they would say it's not part of their library and therefore can't help me.

[DarrylBurke]

Well, I'm not asking for help regarding the acm library.

To get better help sooner, post a SSCCE (Short, Self Contained, Correct (Compilable), Example) that demonstrates the problem. An SSCCE that doesn't use the acm library.

db

[kammce]

Why are you using MouseEvent for this? You could, but it is much simpler to use itemStateChanged, since it was built for checkBoxes and many other components. Check out this tutorial so you can adjust your code accordingly.

How to Use Buttons, Check Boxes, and Radio Buttons (The Java™ Tutorials > Creating a GUI With JFC/Swing > Using Swing Components)

Also, you did not put a listener on your JCheckBox. You added it init() which is an extension of GraphicsProgram() whatever that is. Check out the tutorial, it will help to figure out how to correctly place a listener on a JCheckBox.

[newbie106]

I solved the problem by removing the SOUTH from the add(checkbox) and now it works just fine