if statement

[Johanis]

When the if statement is true it displays the error message as well. It also displays the error message twice when the statement is not true. Any ideas on why and how to fix it?

private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        String getPassword = password.getText();
        String getUsername = username.getText();
       
        for(int tel = 0; tel<data1.length; tel++)
        {
            if((getUsername.equals(data1[tel].getUsername()))&&(getPassword.equals(data1[tel].getPassword())))
            {   Aktiwiteitupdate up = new Aktiwiteitupdate();
                up.welkomnam.setText(getUsername+"!");
                this.setVisible(false);               
            }
            else
          {
                JOptionPane.showMessageDialog(null, "Wrong username or password.","ERROR",JOptionPane.ERROR_MESSAGE);
          }
        }

    }

[JosAH]

For each and every element from your 'data1' array it checks whether it is correct or incorrect; that's what you told it to do ...

kind regards,

Jos

[Johanis]

I changed it to this now and there's still something wrong.

private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        String getPassword = password.getText();
        String getUsername = username.getText();
        int gekry = 0;
        int tel = 0;
        while(gekry == 0)
        {
            if((getUsername.equals(data1[tel].getUsername()))&&(getPassword.equals(data1[tel].getPassword())))
            {   Aktiwiteitupdate up = new Aktiwiteitupdate();
                tel = tel+1;
                System.out.println(tel);
                up.welkomnam.setText(getUsername+"!");
                gekry = 1;
                this.setVisible(false);
            }
            else
          {
                JOptionPane.showMessageDialog(null, "Wrong username or password.","ERROR",JOptionPane.ERROR_MESSAGE);
          }
        }

    }

[JosAH]

What does 'still something wrong' mean? Do daemons fly out of your nostrils?

kind regards,

Jos

[Johanis]

Whether I log in with the right username and password or not it displays the error, and it won't go away.

[ics1010]

Your logic is a bit fuzzy. You're checking a list of potential un/pw combos against a single input un/pw. You're set up now to display an error for each time it fails and since it fails to update any counters on that event, you're in an endless loop. If that's the way you need it, put your control loop back in and you need something like this...
int match = 0;
for(tel = 0; tel < data1.len; tel++) {
if(data1[tel] == positive_match) {
match = 1;
break;
}
}
if(match == 1) {
// un/pw has matched so act accordingly
}
else {
// un/pw failed all matches so act accordingly
}

[Tolls]

You might need to give some more detail here.
What is data1.
What is the loop attempting to do?

It looks to me like you're trying to find the username/password combination in that array?

[Johanis]

Your logic is a bit fuzzy. You're checking a list of potential un/pw combos against a single input un/pw. You're set up now to display an error for each time it fails and since it fails to update any counters on that event, you're in an endless loop. If that's the way you need it, put your control loop back in and you need something like this...
int match = 0;
for(tel = 0; tel < data1.len; tel++) {
if(data1[tel] == positive_match) {

Just as I wanted to reply that I got it right, I saw your message :). Thanks, I did a similar thing to what you were suggesting. My code now looks like this:

match = 1;
break;
}
if(match == 1) {
// un/pw has matched so act accordingly
}
else {
// un/pw failed all matches so act accordingly
}

private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {                                         
        String getPassword = password.getText();
        String getUsername = username.getText();
        int verander = 0;
        
        for(int tel = 0; tel<data1.length; tel++)
        {
            if((getUsername.equals(data1[tel].getUsername()))&&(getPassword.equals(data1[tel].getPassword())))
            {   
                verander = 1;
                               
            }
        }
        if(verander == 1)
        {
            Aktiwiteitupdate up = new Aktiwiteitupdate();
            up.welkomnam.setText(getUsername+"!");
            this.setVisible(false);
        }
        else
        {
            JOptionPane.showMessageDialog(null, "Wrong username or password.","ERROR",JOptionPane.ERROR_MESSAGE);
        }

    }

[JosAH]

I'd split things up in two separate (and simpler methods): 1) a method that tries to find a username/password combination in that array; it could return the index in the array or -1 if nothing was found; 2) a method that takes the appropriate action depending on the supplied username/password combination. That untangles the control flow of the program ...

kind regards,

Jos

[Johanis]

I'd split things up in two separate (and simpler methods): 1) a method that tries to find a username/password combination in that array; it could return the index in the array or -1 if nothing was found; 2) a method that takes the appropriate action depending on the supplied username/password combination. That untangles the control flow of the program ...

kind regards,

Jos

thanks Jos, but I got it working (above). Ill remember your recommendations for future reference. Thanks again.