Help in Radion Buttons

[tjt]

Hello,
How do I deselect a radio button when I click my reset button?
I tried radiobutton.setSelected(false); and seems to be not the right code.
I also tried buttongroup.setselection and its not working or I just dont know how to use it?

[tjt]

Here is what I really did :D

[Fubarable]

If you're using Java 1.6 or 1.7, you could always call the ButtonGroup#clearSelection() method.

In the future, please post your real code here using code tags, not images, as it makes it much easier for us to copy, paste and test. Welcome to the java-forums, by the way!

[tjt]

package rockpaperscissorsGUI;

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;

import javax.swing.Box;
import javax.swing.ButtonGroup;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
import javax.swing.JTextField;



public class RockPaperScissors implements ActionListener {

	JFrame frame;
	JPanel panel , radio1panel , radio2panel;
	JLabel player1 , player2;
	JRadioButton rock , paper,scissors , rock1 , paper1 , scissors1;
	JButton winner , reset;
	Box box;
	JTextField name1,name2;
	
	
public RockPaperScissors(){
	frame = new JFrame("Rock, Paper, Scissors JUDGE!");
	panel = new JPanel();
	player1 = new JLabel("Player 1");
	player2 = new JLabel("Player 2");
	rock = new JRadioButton("Rock");
	paper = new JRadioButton("Paper");
	scissors = new JRadioButton ("Scissors");
	rock1 = new JRadioButton("Rock");
	paper1 = new JRadioButton("Paper");
	scissors1 = new JRadioButton("Scissors");
	winner = new JButton("Check the Winner");
	reset = new JButton("Reset");
	name1 = new JTextField("Player 1");
	name2 = new JTextField("Player 2");
	//name1.setSize(10,10);
	//name2.setSize(10,10);
	 //Group the radio buttons. for player 1
    ButtonGroup group = new ButtonGroup();
    group.add(rock);
    group.add(paper);
    group.add(scissors);
    
    // group the radio buttons for player 2
    ButtonGroup group2 = new ButtonGroup();
    group2.add(rock1);
    group2.add(paper1);
    group2.add(scissors1);
    
    //group in a panel
   
  
    
    
    frame.add(panel);
    //panel.add(player1);
    
    panel.add(name1);
    panel.add(rock);
    panel.add(paper);
    panel.add(scissors);
    /*
    panel.add(radio2panel);
    radio2panel.add(rock1);
    radio2panel.add(paper1);
    radio2panel.add(scissors1);
    
    panel.add(radio1panel);
    radio1panel.add(rock);
    radio1panel.add(paper);
    radio1panel.add(scissors);*/
    //panel.add(player2);
    panel.add(name2);
    panel.add(rock1);
    panel.add(paper1);
    panel.add(scissors1);
    
   
    panel.add(winner);
    winner.addActionListener(this);
    panel.add(reset);
    reset.addActionListener(this);
    rock.setMnemonic(KeyEvent.VK_R);
    paper.setMnemonic(KeyEvent.VK_P);
    scissors.setMnemonic(KeyEvent.VK_S);
    rock1.setMnemonic(KeyEvent.VK_O);
    paper1.setMnemonic(KeyEvent.VK_A);
    scissors1.setMnemonic(KeyEvent.VK_C);
    winner.setMnemonic(KeyEvent.VK_W);
    frame.setSize(300,150);
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.setLocationRelativeTo(null);
    frame.setVisible(true);
    
	
	}
public static void main(String[] args){
	
	new RockPaperScissors();
	
}

@Override
public void actionPerformed(ActionEvent event) {
	String player1name , player2name;
	player1name = name1.getText();
	player2name = name2.getText();
	if (event.getSource()==winner)
		{
			if ((rock.isSelected()) && (paper1.isSelected()))
					JOptionPane.showMessageDialog(null, "The winner is "+ player2name + "! \nCongratulations!"  
							,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((rock.isSelected()) && (scissors1.isSelected()))
			JOptionPane.showMessageDialog(null, "The winner is "+ player1name + "! \nCongratulations!"  
					,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((rock.isSelected()) && (rock1.isSelected()))
			JOptionPane.showMessageDialog(null, "It's a tie! \nCongratulations!"  
					,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			
			else if ((paper.isSelected()) && (rock1.isSelected()))
				JOptionPane.showMessageDialog(null, "The winner is "+ player1name + "! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((paper.isSelected()) && (scissors1.isSelected()))
				JOptionPane.showMessageDialog(null, "The winner is "+ player2name + "! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((paper.isSelected()) && (paper1.isSelected()))
				JOptionPane.showMessageDialog(null, "It's a tie! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			
			else if ((scissors.isSelected()) && (rock1.isSelected()))
				JOptionPane.showMessageDialog(null, "The winner is "+ player2name + "! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((scissors.isSelected()) && (scissors1.isSelected()))
				JOptionPane.showMessageDialog(null, "It's a tie! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else if ((scissors.isSelected()) && (paper1.isSelected()))
				JOptionPane.showMessageDialog(null, "The winner is "+ player1name + "! \nCongratulations!"  
						,"Rock Paper and Scissors Judge", JOptionPane.INFORMATION_MESSAGE);
			else JOptionPane.showMessageDialog(null, "Please Select from the options! \n Thank you"  
					,"Rock Paper and Scissors Judge", JOptionPane.ERROR_MESSAGE);
		}
	if (event.getSource()==reset)
		{name1.setText("Player 1");
		name2.setText("Player 2");
		/*
		rock.setSelected(false);
		rock1.setSelected(false);
		paper.setSelected(false);
		paper1.setSelected(false);
		scissors1.setSelected(false);
		scissors.setSelected(false);*/
		//to be continued
		//group.setSelection
		
		//group.getSelectedJRadioButton();
		/*if (scissors.isSelected())
			scissors.setSelected(false);*/
		
		}
	
	
}
}

sorry I don't know how to use code tags so I copied the whole code
I'm also new to GUI and I mad a judge for rock paper and scissors..
Is there another way besides clearSelection?

[Fubarable]

sorry I don't know how to use code tags so I copied the whole code

I've edited your post and have added code tags. To do this yourself in the future, simply highlight your code and press the code button at the top of the editor window, either that or surround your code with [code] [/code] tags.

I'm also new to GUI and I mad a judge for rock paper and scissors..
Is there another way besides clearSelection?

First please tell us why you're dead set against using clearSelection(). It's the obvious solution to your problem, so why use a kludge without a good reason, and if you have a good reason, then please let us know?

[tjt]

I've edited your post and have added code tags. To do this yourself in the future, simply highlight your code and press the code button at the top of the editor window, either that or surround your code with [code] [/code] tags.

Thanks :D

and clearSelection seems to be not working or did I use the code incorrectly ??? or should I update my java?

[Fubarable]

and clearSelection seems to be not working or did I use the code incorrectly ??? or should I update my java?

???

It's hard to say anything since you don't show us how you tried to use it or what errors or problems it caused. Consider giving us more information.

[tjt]

here.. I'm really new to GUI I really don't know what to do.. :D

[Fubarable]

This has nothing to do with Swing, nothing to do with ButtonGroups, and all to do with your variable being out of scope. Your current ButtonGroup variable, group, is declared in the class's constructor and is thus only visible inside of the constructor. Declare it in the class as a non-static field, make sure that you don't re-declare it in the constructor and then you'll be able to use it throughout the class.

[tjt]

hmm can you show it via coding and where to place it in my code?.. I can't understand what you're saying.. I'm sorry i'm really new :D Thank you

[Fubarable]

Simply take ButtonGroup group = new ButtonGroup() outside of the constructor and put it in the class, that's it. If you declare it in the constructor, ButtonGroup group, then it is only visible in the scope in which it was declared, here the constructor. You need it visible outside of the constructor. Please google and read up on variable scope as you really need to fully understand this concept, not just the fix for this program.

[tjt]

Ok thanks

[tjt]

Now, it's working thanks..

[Fubarable]

You're welcome, but more importantly, do you understand the problem, because it's sure to come up again in a different program?

[tjt]

hmm just a little bit. but i'll read more about GUI can you recommend any links or ebooks??? I'm using this link to study about GUI Trail: Creating a GUI With JFC/Swing (The Java™ Tutorials) but I get more of the answers to my questions here :D

[DarrylBurke]

You have to learn Java before you tackle Swing. Here are some references related to the issue Fubarable helped you with:
Variables (The Java™ Tutorials > Learning the Java Language > Language Basics)
Passing Information to a Method or a Constructor (The Java™ Tutorials > Learning the Java Language > Classes and Objects)
Chapter*6.*Names

db

[tjt]

Thank You!