Text file to Array working values

[kraster]

So i got a 100.000 entries in a text file, each on a row. I wanna calculate the inversions of them but seems there is a problem

import java.io.*;
import java.util.*;


public class Inversions{

    public static void main(String [] args){
    
    Scanner s = new Scanner("list.txt");
    ArrayList<String> lista = new ArrayList<String>();
    while (s.hasNext()){
        lista.add(s.next());
        
    }
    s.close();
    int x=0;
    for(int i=0;i<lista.size();i++)
    {
        for(int j=i+1;j<=lista.size();j++){
        
            if(lista.get(i).compareTo(lista.get(j))>0) x++;
        
        }        
    }
    
    


}

I can't operate with the values from 'lista' in any way..

[Fubarable]

What happens? What errors, if any, do you see?

[Fubarable]

Also some general suggestions:

• Don't use a count variable, but rather simply get the List's size via its size() method.
• Lists such as ArrayLists are like arrays in that they are 0-based. Their indexes start at 0 and go up to size() - 1.
• For this reason, for loops that iterate through Lists such as ArrayLists usually go from index 0 to index < myList.size(), not index <= myList.size(); as the latter will result in an ArrayIndexOutOfBoundsException.

[kraster]

array required, but java.util.ArrayList<java.lang.String> found // where i do the if. and thanks for the tips btw:)

[Fubarable]

array required, but java.util.ArrayList<java.lang.String> found // where i do the if. and thanks for the tips btw:)

Ah yes, OK. You are trying to use an ArrayList as if it were an array. You don't use array indices [i] with Lists such as ArrayLists, but rather you use the get(i) method.

[kraster]

can u write down that specific line? Cause i didn't really get it how to implement the get method. So all i wanna do that line is to compare 2 numbers and in case of first being bigger to increase x.

[cselic]

^Instead of using for example lista[i] you should use lista.get(i)

[kraster]

^^ it works. but now when i try to run, it says : java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
at java.util.ArrayList.rangeCheck(ArrayList.java:604)
at java.util.ArrayList.get(ArrayList.java:382)
at Inversions.main(Inversions.java:21)

[Fubarable]

^^ it works. but now when i try to run, it says : java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
at java.util.ArrayList.rangeCheck(ArrayList.java:604)
at java.util.ArrayList.get(ArrayList.java:382)
at Inversions.main(Inversions.java:21)

Please re-read my second post to this thread. Also, you'll want to put in some code to test that data is being read in correctly. In the loop where you read in information from the text file, consider printing out each line to the console just temporarily to be sure it's working OK. Once you've got all working, you'll then remove this test code.

[kraster]

I'm new to java and don't really know what to write. System.out.println of what in that while? Cause lista returns list.txt.. I had a version with bufferedreader working but that displayed me only like 100 out of 100.000.. and i've took ur advices since i first saw them(related to ur 2nd post)

/edit ; edited my first post with what i got till now.

[Fubarable]

I was suggesting something like this:

    while (s.hasNext()){
        String line = s.next();
        lista.add(line);

        // the following is to test to make sure that you're reading the file correctly
        System.out.println("line: " + line); // delete this line of code once you know all works well.

    }