ive tried a million ways but cant call a simple method on an array list object Help

[smande3]

Maybe im going about this whole thing in a dumb way but im just trying to construct a deck of cards and can not figure it out my problem always comes to null pointer reference when i call a arraylist.get(index).getsomething() please help me

class creates card objects:

import java.util.ArrayList;

class Card  {
	int value;
	String rank;
	String suit;
	String cardRankAndSuit;
	
	public Card(int v)  {
		value = v;
		
		String [] ranks = {"Ace", "King", "Queen", "Jack", "Ten", "Nine", "Eight", "Seven", "Six", "Five", "Four", "Three", "Two"};		

		for(int i = 0; i<13; i++){	
			if( (value == i) || (value == i+13) || (value == i+26) || (value == i+39) ) {
				rank = ranks[i];
				}
			}

		if(value <13){
			suit = "Spades";
			}
		if(value >12 && value <26){
			suit = "Hearts";
			}
		if(value >25 && value <39){
			suit = "Diamonds";
			}
		if(value >38){
			suit = "Clubs";
			}

		cardRankAndSuit = rank + " of " + suit;
		}

	public int getValue()  {
		return value;
		}

	public String getCardRankAndSuit()  {
		return cardRankAndSuit;
		}	

	}

class creates deck to hold cards ( and is supposed to call from the deck array list a specific hard (problem area in bold):

import java.util.ArrayList;

class Deck  {

	boolean hasCards;
	ArrayList<Card> deck;
	int position;
	String cardSpoken;
	
	

	public void setUpDeck()  {
		ArrayList<Card> deck = new ArrayList<Card>();
		hasCards = true;

		for(int i = 0; i<52; i++){
			Card card = new Card(i);
			deck.add(card);
			}
		}

[B]	public void pickCard(int p)  {
		position = p;
		cardSpoken = deck.get(position).getCardRankAndSuit();
		}[/B]
	public String getPickedCard()  {
		return cardSpoken;
		}

	}

simple test class to pick a random card and display it:

class DealOutDeck  {



	public static void main(String  [] args)  {
		Deck newDeck = new Deck();
		newDeck.setUpDeck();
		int randomCardInDeck = (int) (Math.random() * 52);
		newDeck.pickCard(randomCardInDeck);
		System.out.println(newDeck.getPickedCard());
			}
		}

[pbrockway2]

Your Deck class declares two different deck variables. The one you declare in setUpDeck() will hide the instance variable one and, because it is a local variable, it will disappear when the setUpDeck() method finishes.

-----

If you still have trouble post the stack trace associated with the NullPointerException.

[Ronin]

Your Deck class declares two different deck variables. The one you declare in setUpDeck() will hide the instance variable one and, because it is a local variable, it will disappear when the setUpDeck() method finishes.

Put simply, code on line 13 should read

deck = new ArrayList<Card>();

note the missing declaration.

Regards.

[smande3]

Thank you both. Works fine now