BSTree

[Fotis]

Hi programmers.

Please check if the following BSTree is ok?

I only want to crate a BSTree of Strings, nothing else.

import java.util.Scanner;

class Node {
    private Node left;
    private String number;
    private Node right;

    public Node() {
        left = null;
        number = "0";
        right = null;
    }

    public Node(String x) {
        left = null;
        number = x;
        right = null;
    }

    public String getNumber() {
        return number;
    }

    public Node getLeft() {
        return left;
    }

    public Node getRight() {
        return right;
    }

    public void setNum(String x){
        number = x;
    }

    public void setLeft(Node leftNode) {
        left = leftNode;
    }

    public void setRight(Node rightNode) {
        right = rightNode;
    }

}

  class BST{
    private Node root;

    public BST(){
        root = null;
    }



    public boolean isEmpty(){
            return root == null;
    }


    public void insert(String x){
        insertData(x, root);
    }


    private void insertData(String n, Node p){
        if(p == null){
            p = new Node(n);
            root = p;
        } else if(n.compareTo(p.getNumber()) < 0){
            if(p.getLeft() == null){
                p.setLeft(new Node(n));
            } else {
                p = p.getLeft();
                insertData(n,p);
            }
        } else {
            if(p.getRight() == null){
                p.setRight(new Node(n));
            } else {
                p = p.getRight();
                insertData(n, p);
            }
        }
    }
}

 public class BinarySearchTree{
        public static void main(String[] args){
            BST tree = new BST();
            Scanner in = new Scanner(System.in);        
            for (int y=0; y<5;y++){                      
                String x = in.nextLine();
                tree.insert(x);
}

        }
    }

Thank you.

[JosAH]

Please check if the following BSTree is ok?

Why should we check it? Have you checked it yourself? Does it work? If not, tell us what exactly doesn't work but don't assume we figure it out all by ourselves.

kind regards,

Jos

[Fotis]

I made it and i don't know if it is a correct Binary Search Tree.

Just i want be sure for this.

[JosAH]

I made it and i don't know if it is a correct Binary Search Tree.

Just i want be sure for this.

Does it do what you want it to do? Have you tested it? Do you want a formal correctness proof?

kind regards,

Jos

[Fotis]

Do you want a formal correctness proof?

Just this.
I believe that it is correct. I just want be sure.

[JosAH]

Just this.
I believe that it is correct. I just want be sure.

Ok, if you want an answer without asking a proper question: no that is not a proper search tree; it isn't balanced.

kind regards,

Jos